Re: flyspell.el and non-word characters in CASECHARS

[Agustin Martin <agustin.martin@hispalinux.es>]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On Wed, Apr 18, 2012 at 09:45:41PM +0300, Eli Zaretskii wrote:
> > Date: Wed, 18 Apr 2012 18:26:19 +0200
> > From: Agustin Martin <agustin.martin@hispalinux.es>
> > 
> > > I actually _added_ to the word-syntax test the test against CASECHARS,
> > > like this:
> > > 
> > >    ((or (and (= flyspell-pre-point (- (point) 1))
> > > 	     (or (eq (char-syntax (char-after flyspell-pre-point)) ?w)
> > > 		 (string-match-p (flyspell-get-casechars)
> > > 				 (buffer-substring-no-properties
> > > 				  flyspell-pre-point (1+ flyspell-pre-point)))))
> > > 	(= flyspell-pre-point (point))
> > > 	(= flyspell-pre-point (+ (point) 1)))
> > >     nil)
> > 
> > I tested with your changes and they do not seem to help here.
> 
> Those were not all of the changes, I just showed them for an
> illustration.  The full change involved a similar change a few lines
> below the above snippet, where again flyspell checks the word syntax.

I noticed that part when first looking and later forgot about it. Thanks for
reminding.

Updated diff attached for wider testing.

Regards,

-- 
Agustin

[-- Attachment #2: flyspell.el_use-otherchars.2.diff --]
[-- Type: text/x-diff, Size: 2046 bytes --]

--- flyspell.el.orig	2012-04-12 15:06:12.780784001 +0200
+++ flyspell.el	2012-04-19 11:05:07.936947902 +0200
@@ -739,7 +739,11 @@
 	 (eq flyspell-pre-pre-buffer flyspell-pre-buffer))
     nil)
    ((or (and (= flyspell-pre-point (- (point) 1))
-	     (eq (char-syntax (char-after flyspell-pre-point)) ?w))
+	     (or (eq (char-syntax (char-after flyspell-pre-point)) ?w)
+		 (string-match-p (ispell-get-otherchars)
+		  		 (buffer-substring-no-properties
+		  		  flyspell-pre-point (1+ flyspell-pre-point)))
+		 ))
 	(= flyspell-pre-point (point))
 	(= flyspell-pre-point (+ (point) 1)))
     nil)
@@ -753,7 +757,11 @@
 	     ;; If other post-command-hooks change the buffer,
 	     ;; flyspell-pre-point can lie past eob (bug#468).
 	     (null (char-after flyspell-pre-point))
-	     (eq (char-syntax (char-after flyspell-pre-point)) ?w)))
+	     (or (eq (char-syntax (char-after flyspell-pre-point)) ?w)
+		 (string-match-p (ispell-get-otherchars)
+				 (buffer-substring-no-properties
+				  flyspell-pre-point (1+ flyspell-pre-point)))
+		 )))
     nil)
    ((not (eq (current-buffer) flyspell-pre-buffer))
     t)
@@ -815,6 +823,7 @@
 	 (save-excursion
 	   (backward-char 1)
 	   (and (looking-at (flyspell-get-not-casechars))
+		(not (looking-at (ispell-get-otherchars)))
 		(or flyspell-consider-dash-as-word-delimiter-flag
 		    (not (looking-at "-"))))))
     ;; yes because we have reached or typed a word delimiter.
@@ -880,6 +889,7 @@
 				     (save-excursion
 				       (backward-char 1)
 				       (and (and (looking-at (flyspell-get-not-casechars)) 1)
+					    (not (looking-at (ispell-get-otherchars)))
 					    (and (or flyspell-consider-dash-as-word-delimiter-flag
 						     (not (looking-at "\\-"))) 2))))))
 			  c))))
@@ -895,6 +905,7 @@
 				       (save-excursion
 					 (backward-char 1)
 					 (and (looking-at (flyspell-get-not-casechars))
+					      (not (looking-at (ispell-get-otherchars)))
 					      (or flyspell-consider-dash-as-word-delimiter-flag
 						  (not (looking-at "\\-"))))))))
 			    c))