From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: martin rudalics <rudalics@gmx.at>, emacs-devel@gnu.org
Subject: Re: Musings: Supposed places of safety, guaranteed by parse-partial-sexp are not safe.
Date: Mon, 5 Dec 2011 11:35:03 +0000 [thread overview]
Message-ID: <20111205113503.GB3522@acm.acm> (raw)
In-Reply-To: <jwvhb1fpueu.fsf-monnier+emacs@gnu.org>
Hello, Stefan,
On Sun, Dec 04, 2011 at 10:33:37PM -0500, Stefan Monnier wrote:
> >>> If you change (nth 5 ppss) you would still have to say that (nth 4 ppss)
> >>> is unreliable in this special case.
> >> Not if (nth 5 ppss) says that the buffer position is the one *after* the
> >> "/*" sequence. Of course for "*/" we'd conversely want to use the state
> >> *before* "*/".
> > What I meant was that the caller would have to care about (nth 5 ppss)
> > too, wherever she now looked only at (nth 3 ppss) and (nth 4 ppss).
> That's what I understood and my suggestion does address this issue (tho
> it means that (nth 5 ppss) will sometimes refer to a buffer position
> after (point) and sometimes before).
I think this is very wrong, and will lead to unwanted complications. I
would suggest this:
5. `t' if point is just after a quote character. The character just
scanned if that might be part of a double character comment boundary.
This should be straightforward to hack.
However, there will be crazy hackers who have tested (nth 5 ppss) as
being non-nil, rather than looking for t. :-( I say, tough on them.
> A case that needs to work is "/*/" in C mode, for example.
The above suggestion would handle this appropriately.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2011-12-05 11:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 23:23 Musings: Supposed places of safety, guaranteed by parse-partial-sexp are not safe Alan Mackenzie
2011-12-03 23:40 ` Daniel Colascione
2011-12-04 3:39 ` Stefan Monnier
2011-12-04 10:41 ` martin rudalics
2011-12-04 15:21 ` Stefan Monnier
2011-12-04 17:06 ` martin rudalics
2011-12-04 20:47 ` Andreas Röhler
2011-12-05 3:33 ` Stefan Monnier
2011-12-05 7:41 ` martin rudalics
2011-12-05 14:01 ` Stefan Monnier
2011-12-05 11:35 ` Alan Mackenzie [this message]
2011-12-05 11:25 ` Alan Mackenzie
2011-12-06 10:15 ` martin rudalics
2011-12-06 10:33 ` Alan Mackenzie
2011-12-06 13:39 ` martin rudalics
2011-12-06 13:50 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205113503.GB3522@acm.acm \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).