From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mike Kazantsev Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] notifications.el: fixed image-data and image-path hints passing Date: Mon, 7 Nov 2011 14:29:11 +0600 Message-ID: <20111107142911.1822efa2@malediction> References: <20111107142230.37ce20ec@malediction> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/JHLcQXGr91FFgsDcriIAd//"; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1320654574 6189 80.91.229.12 (7 Nov 2011 08:29:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2011 08:29:34 +0000 (UTC) Cc: Julien Danjou To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 09:29:23 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RNKa2-00009A-GB for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2011 09:29:22 +0100 Original-Received: from localhost ([::1]:59375 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNKa1-00029k-TG for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2011 03:29:21 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:53766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNKZy-00029R-Ir for emacs-devel@gnu.org; Mon, 07 Nov 2011 03:29:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNKZx-0000ol-Ew for emacs-devel@gnu.org; Mon, 07 Nov 2011 03:29:18 -0500 Original-Received: from mail-ey0-f169.google.com ([209.85.215.169]:41034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNKZx-0000oh-99 for emacs-devel@gnu.org; Mon, 07 Nov 2011 03:29:17 -0500 Original-Received: by eye4 with SMTP id 4so3628104eye.0 for ; Mon, 07 Nov 2011 00:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; bh=mvbkW1PguOWR3G48lAxyhN3CP40Q/werPsXdTjnvS1Y=; b=aRNB/jQilpJrEaKIDw21xBW0EHcr+W6I+gW1HCPKM1gebiRRe1Gk76TOp0SBjzNDfX 1SydRgeTUhmq+FCMzvim6epsi7vykQ1pwlP/hJkOBnWCHEujV/c7wCVUsMpg6adQCqO2 0fOMZdroTs6cetCkfiICRxJW7F1/tNUfkHMnU= Original-Received: by 10.213.19.198 with SMTP id c6mr791987ebb.148.1320654555432; Mon, 07 Nov 2011 00:29:15 -0800 (PST) Original-Received: from malediction (wall.mplik.ru. [195.58.1.141]) by mx.google.com with ESMTPS id d6sm48190539eec.10.2011.11.07.00.29.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Nov 2011 00:29:14 -0800 (PST) In-Reply-To: <20111107142230.37ce20ec@malediction> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.24.7; i686-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.215.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:145920 Archived-At: --Sig_/JHLcQXGr91FFgsDcriIAd// Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 7 Nov 2011 14:22:30 +0600 Mike Kazantsev wrote: >=20 > Good day, >=20 > Before the patch, hints were passed as "image_path" and "image_data", > which is incorrect, as Desktop Notifications Specification v1.2 clearly > states: >=20 > The icon is defined by the "app_icon" parameter. The image can be > defined by the "image-path", the "image-data" hint or the deprecated > "icon_data" hint. >=20 > Most common (by far) implementation of spec - libnotify - seem to pass > them as described in spec as well, so current behavior looks like a bug. >=20 Actually looking at previous spec versions (which can be found on http://www.galago-project.org/specs/notification/), there seemed to be an "icon_data" hint in 0.9, but not "icon_path", so I can guess that's where these came from. Mentioned specs seem to be fairly obsolete now, and even if they should be supported, there doesn't seem to be any excuse to pass "icon_path". > Patch to pass "image-path" and "image-data" hints - as per spec - is > attached below. >=20 > Desktop Notifications Specification: >=20 > http://developer.gnome.org/notification-spec/#icons-and-images > http://people.gnome.org/~mccann/docs/notification-spec/notification-spe= c-latest.html#icons-and-images >=20 ... --=20 Mike Kazantsev // fraggod.net --Sig_/JHLcQXGr91FFgsDcriIAd// Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) iEYEARECAAYFAk63ltcACgkQASbOZpzyXnFEygCfViVhtReZp3YkmSrjyBTM5vlP TuoAniMOSBGrCgRK410nGhxKELS2GnCO =osFh -----END PGP SIGNATURE----- --Sig_/JHLcQXGr91FFgsDcriIAd//--