Re: [PATCH] notifications.el: fixed image-data and image-path hints passing

[Mike Kazantsev <mk.fraggod@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

On Mon, 7 Nov 2011 14:22:30 +0600
Mike Kazantsev <mk.fraggod@gmail.com> wrote:

> 
> Good day,
> 
> Before the patch, hints were passed as "image_path" and "image_data",
> which is incorrect, as Desktop Notifications Specification v1.2 clearly
> states:
> 
>   The icon is defined by the "app_icon" parameter. The image can be
>   defined by the "image-path", the "image-data" hint or the deprecated
>   "icon_data" hint.
> 
> Most common (by far) implementation of spec - libnotify - seem to pass
> them as described in spec as well, so current behavior looks like a bug.
> 

Actually looking at previous spec versions (which can be found on
http://www.galago-project.org/specs/notification/), there seemed to be
an "icon_data" hint in 0.9, but not "icon_path", so I can guess that's
where these came from.

Mentioned specs seem to be fairly obsolete now, and even if they
should be supported, there doesn't seem to be any excuse to pass
"icon_path".


> Patch to pass "image-path" and "image-data" hints - as per spec - is
> attached below.
> 
> Desktop Notifications Specification:
> 
>   http://developer.gnome.org/notification-spec/#icons-and-images
>   http://people.gnome.org/~mccann/docs/notification-spec/notification-spec-latest.html#icons-and-images
> 
...


-- 
Mike Kazantsev // fraggod.net

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]