imenu fails to index C function with function pointer as parameter

imenu fails to index C function with function pointer as parameter

[Liang Wang]

Hi,

When I try to jump to a function definition which has a function
pointer as one of its parameters, imenu fails to recognize such
function.  One example is

static rtx
substitute_address (rtx exp, rtx (*no_address_fn) (rtx),
		    rtx (*address_fn) (rtx))

which is from gcc source code in gcc/genattrtab.c.

To reproduce it, run

M-x imenu RET sub TAB

And then, I get [No match].  Other functions are just fine.


Thanks,
Liang.

Re: imenu fails to index C function with function pointer as parameter

[Alan Mackenzie]

Hi, Liang.

On Mon, Aug 22, 2011 at 02:02:12PM +0800, Liang Wang wrote:
> Hi,

> When I try to jump to a function definition which has a function
> pointer as one of its parameters, imenu fails to recognize such
> function.  One example is

> static rtx
> substitute_address (rtx exp, rtx (*no_address_fn) (rtx),
> 		    rtx (*address_fn) (rtx))

> which is from gcc source code in gcc/genattrtab.c.

> To reproduce it, run

> M-x imenu RET sub TAB

> And then, I get [No match].  Other functions are just fine.

This is a bug.  I'm looking at it at the moment.  Hopefully I'll have a
fix in a few days.

> Thanks,
> Liang.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: imenu fails to index C function with function pointer as parameter

[Alan Mackenzie]

Hi, Liang.

On Mon, Aug 22, 2011 at 02:02:12PM +0800, Liang Wang wrote:
> Hi,

> When I try to jump to a function definition which has a function
> pointer as one of its parameters, imenu fails to recognize such
> function.  One example is

> static rtx
> substitute_address (rtx exp, rtx (*no_address_fn) (rtx),
> 		    rtx (*address_fn) (rtx))

> which is from gcc source code in gcc/genattrtab.c.

> To reproduce it, run

> M-x imenu RET sub TAB

> And then, I get [No match].  Other functions are just fine.

Thanks for taking the trouble to report this bug.  I think this patch
fixes it.  Would you please try it out and confirm it's OK.


*** orig/cc-menus.el	2011-08-26 17:24:29.000000000 +0000
--- cc-menus.el	2011-08-26 19:22:03.000000000 +0000
***************
*** 110,117 ****
         "[^" c-alnum "_:<>~]"		      ; match any non-identifier char
         "\\([" c-alpha "_][" c-alnum "_:<>~]*\\)" ; match function name
         "\\([ \t\n]\\|\\\\\n\\)*("	      ; see above, BUT the arg list
!        "\\([ \t\n]\\|\\\\\n\\)*\\([^ \t\n(*][^)]*\\)?)" ; must not start
!        "\\([ \t\n]\\|\\\\\n\\)*[^ \t\n;(]"    ; with an asterisk or parentheses
         ) 1)
      ;; Special case for definitions using phony prototype macros like:
      ;; `int main _PROTO( (int argc,char *argv[]) )'.
--- 110,120 ----
         "[^" c-alnum "_:<>~]"		      ; match any non-identifier char
         "\\([" c-alpha "_][" c-alnum "_:<>~]*\\)" ; match function name
         "\\([ \t\n]\\|\\\\\n\\)*("	      ; see above, BUT the arg list
!        "\\([ \t\n]\\|\\\\\n\\)*"	      ; must not start
!        "\\([^ \t\n(*]"			      ; with an asterisk or parentheses
!        "[^()]*\\(([^()]*)[^()]*\\)*"	      ; Maybe function pointer arguments
!        "\\)?)"
!        "\\([ \t\n]\\|\\\\\n\\)*[^ \t\n;(]"
         ) 1)
      ;; Special case for definitions using phony prototype macros like:
      ;; `int main _PROTO( (int argc,char *argv[]) )'.


> Thanks,
> Liang.

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: imenu fails to index C function with function pointer as parameter

[Angelo Graziosi]

Hi Alan,

> I think this patch
> fixes it

this bug looks similar to that flagged here:

   https://lists.gnu.org/archive/html/bug-gnu-emacs/2011-07/msg02023.html


Have you idea/suggestions about it?

Thanks,
Angelo.