From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.devel Subject: Re: request for reviewing the updated version of cc-guess.el Date: Wed, 23 Mar 2011 19:24:43 +0900 (JST) Organization: Red Hat Japan, Inc. Message-ID: <20110323.192443.143530944314823184.yamato@redhat.com> References: <20110211.052337.141994890934352619.yamato@redhat.com> <20110323101302.GA2247@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300875910 23354 80.91.229.12 (23 Mar 2011 10:25:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2011 10:25:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: acm@muc.de Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 23 11:25:03 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2LFN-0005Ll-CM for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2011 11:25:01 +0100 Original-Received: from localhost ([127.0.0.1]:48303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2LFL-0004l8-Jj for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2011 06:24:59 -0400 Original-Received: from [140.186.70.92] (port=37978 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2LFB-0004hz-6Z for emacs-devel@gnu.org; Wed, 23 Mar 2011 06:24:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2LF9-0004tw-Ch for emacs-devel@gnu.org; Wed, 23 Mar 2011 06:24:48 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:25160) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2LF9-0004tR-4G for emacs-devel@gnu.org; Wed, 23 Mar 2011 06:24:47 -0400 Original-Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2NAOj2u003570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 23 Mar 2011 06:24:45 -0400 Original-Received: from localhost (beach.nrt.redhat.com [10.64.200.71]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2NAOhhn009996; Wed, 23 Mar 2011 06:24:44 -0400 In-Reply-To: <20110323101302.GA2247@muc.de> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137561 Archived-At: Alan、 > Hello, Masatake. > > I hope you have come through the recent events in Japan OK, and offer my > sincere condolences for any loss you may have suffered. Thanks. I'm O.K. I have not got serious trouble till now. > On Fri, Feb 11, 2011 at 05:23:37AM +0900, Masatake YAMATO wrote: >> Hi, > >> Taking 7 years I've updated cc-guess.el as suggested by Martin >> Stjernholm. > >> Currently cc-guess.el is not included in cc-mode official release and >> as the result it is not included in GNU Emacs. > >> Could you review the updated version with considering inclduing it to >> the release? > > OK. I agree with you that it cc-guess.el should become an integral part > of CC Mode, specifically in the upcoming version 5.32. Thanks for doing > the work! Thanks. > I've read the seven year old Email thread between you and > Martin. > > There are some tasks still to do: > (i) Tidy up the syntax of the doc strings. > (ii) Write a new page in the manual. > (iii) Decide on key bindings. > > The first two of these tasks need to be done by me. Thank you very much. > As for the key > bindings, I don't really like Martin's suggestion of C-c C-g; when > somebody has just typed C-c then decides it was a mistake, he's going to > hit C-g to cancel out of it. Of all the major mode bindings, we have > these ones (abbreviated below) still free: > > C-c C-f > ....C-g Keep free for cancel? > -h > i > j > k > m > r > v > x > y > z > { > } > < > > > : > ; > > . Like Martin, I don't think C-c C-<, etc. are good bindings here - they > should be kept for possible backward/forward commands of some sort. How > about C-c C-j ? The C-j is a bit like the indentation command M-j > `c-indent-new-comment-line'. What do you think? > > Which commands need key bindings? > > [ Change log and elisp file received with thanks and deleted. ] I think no key binding is needed. I think it will not be invoked frequently. However, I think the commands should be listed in "C" pull-down menu. C ... [Style >] [Set Manually (c-set-style) ] [Examine Current Buffer and Guess Style] [Examine Current Buffer, Guess Style and Install It] [Install Guessed Result (cc-guess-install)] [View Guessed Result (cc-guess-view-guessed-style)] or C ... [Set Style Manually (c-set-style) ] [Examine Current Buffer and Guess Style] [Examine Current Buffer, Guess Style and Install It] [Install Guessed Style (cc-guess-install)] [View Guessed Style (cc-guess-view-guessed-style)] The fine controllable indentation engine of cc-mode is the one of the greatest point of cc-mode. So I think "style" menu item should be in C pull-down menu entry. How do you think? Masatake YAMATO