unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Marschke <xxtjaxx@googlemail.com>
To: emacs-devel@gnu.org
Subject: Outline.el: Outlining Perl is failing in a way.
Date: Wed, 2 Feb 2011 16:12:44 +0100	[thread overview]
Message-ID: <20110202151244.GA7309@andres.andreas> (raw)

Hi! 

I like Emacs and I like outline.el, which I frequently use. But it has
a small caveat as I discovered recently. When using outline-minor-mode
on perl-mode with a `sub'(perl-2-lisp:sub->defun). It happens to not
fully wrap-in a function like this:
-*------------------------------------------------------------------*-
sub new {
  my ($class, %parms ) = @_;
  croak("Options to AptPkg::Repackage should be key/value pairs, not hash reference")
    if ref($_[1]) eq 'HASH';

  my $name = delete  $parms{name};
  my $directory = delete  $parms{directory};
  my $verbose = delete  $parms{verbose};
  $verbose = 0 unless defined $verbose;

  print "Build-directory is: ".$directory."\n" if $verbose == 1;
  print "Package-name is: ".$name."\n" if $verbose == 1;

  my $self = bless {
    Package => $name,
    PackageBuildDirectory => $directory,
    Verbose => $verbose
   },$class;

  print "Clean strings...\n" if $verbose == 1;
  $name =~ s:\ ::g if $name =~ m:\ :;
  $directory =~ s:/$::g if $directory =~ m:/$:;

  print "Build-directory is: ".$directory."\n" if $verbose == 1;
  print "Package-name is: ".$name."\n" if $verbose == 1;

  $PackageName = $name;
  $PackageBuildDirectory = $directory."/".$name;
  files();
  return $self;
}
-*------------------------------------------------------------------*-
it only wraps it untill a point like this:
-*------------------------------------------------------------------*-
sub new {...
    Package => $name,
    PackageBuildDirectory => $directory,
    Verbose => $verbose
   },$class;

  print "Clean strings...\n" if $verbose == 1;
  $name =~ s:\ ::g if $name =~ m:\ :;
  $directory =~ s:/$::g if $directory =~ m:/$:;

  print "Build-directory is: ".$directory."\n" if $verbose == 1;
  print "Package-name is: ".$name."\n" if $verbose == 1;

  $PackageName = $name;
  $PackageBuildDirectory = $directory."/".$name;
  files();
  return $self;
}

-*------------------------------------------------------------------*-

Is this fixable? Who is actually the maintainer/developer of
outline.el at the moment? I only found an attribution that it is part
of EMACS and that its © goes to the FSF. What about the person who
wrote it?
 
-- 
Cheers,

Andreas Marschke



                 reply	other threads:[~2011-02-02 15:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110202151244.GA7309@andres.andreas \
    --to=xxtjaxx@googlemail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).