unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Please restore `make-obsolete''s functionality.
Date: Wed, 28 Jul 2010 17:29:59 +0000	[thread overview]
Message-ID: <20100728172959.GA2999@muc.de> (raw)
In-Reply-To: <jwv1vaok3o7.fsf-monnier+emacs@gnu.org>

Hi, Stefan,

On Tue, Jul 27, 2010 at 11:38:09PM +0200, Stefan Monnier wrote:
> > Stefan, the following is a lie - a barefaced lie:
> >     "cc-cmds.el:326:2:Warning: make-obsolete called with 2 arguments, but
> >     requires 3".

> The &optional is obsolete.  So whether it's a lie or not, I'll let you
> decide, but the intention is to let people know that their code needs
> to be updated.

Just to be clear here, I'm thoroughly in favour of the WHEN parameter
being supplied to make-obsolete.  Just that I feel messed around with,
due to the wording of the message.

How about instead being honest with our hackers, and giving a message
something like:

"cc-cmds.el:326:2:Warning: Please consider supplying a third parameter
\"when\" in invocations of make-obsolete".  Is the byte-compiler
flexible enough to support the output of such messages?

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2010-07-28 17:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-26 20:28 Please restore `make-obsolete''s functionality Alan Mackenzie
2010-07-26 20:49 ` Juanma Barranquero
2010-07-26 21:27   ` Alan Mackenzie
2010-07-26 21:46 ` Dan Nicolaescu
2010-07-27 19:45   ` Alan Mackenzie
2010-07-26 21:55 ` Stefan Monnier
2010-07-27 19:41   ` Alan Mackenzie
2010-07-27 21:38     ` Stefan Monnier
2010-07-28 17:29       ` Alan Mackenzie [this message]
2010-07-30  8:58         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100728172959.GA2999@muc.de \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).