* Re: bug#193:
[not found] ` <AANLkTill7PHyqYrJ8BWBN5nP_XLksHl9Dm0rPQvnE8b1@mail.gmail.com>
@ 2010-07-06 19:29 ` Alan Mackenzie
0 siblings, 0 replies; only message in thread
From: Alan Mackenzie @ 2010-07-06 19:29 UTC (permalink / raw)
To: Deniz Dogan; +Cc: 193, Stefan Monnier, emacs-devel
On Sun, Jun 27, 2010 at 02:47:52PM +0200, Deniz Dogan wrote:
> Did anyone ever agree on what needs to be done to fix the problem?
A quick reminder of what the problem is. In C mode (NOT C++ mode):
(i) Type M-q in a pair of short line comments like this
// Two short
// lines.
The command ought to join them into a single line comment. Instead, it
does nothing;
(ii) Type M-q in a line comment which is longer than fill-column:
// A long line comment, which is far far far longer than a moderately or very small fill-column.
This miss-fills by splitting the line, but putting no comment marker on
the new second line:.
// A long line comment, which is far far far longer than a moderately or
very small fill-column.
These bugs are regressions between Emacs 21.4 and 22.1.
#########################################################################
Both these bugs seem to be caused by a strange clause in
`fill-paragraph', where what should be the fill-prefix ("// ") is made
a component of `paragraph-start'. Thus (ii) every line in the comment
sequence is automatically made into its own paragraph; and (i) when
splitting lines, fill-paragraph doesn't insert the fill-prefix when this
is also a paragraph starter.
Here is the strange code:
;; Try to prevent code sections and comment sections from being
;; filled together.
(when (and fill-paragraph-handle-comment comment-start-skip)
(setq paragraph-start
(concat paragraph-start "\\|[ \t]*\\(?:"
comment-start-skip "\\)")))
In C Mode, `comment-start-skip' is "\\(//+\\|/\\*+\\)\\s *".
The two bugs vanish when the above code is removed.
Stefan, can you remember why you put this code in (revision 86672 of
2008-04-11)? Is there perhaps a way of achieving the same effect
without making the fill-prefix match `paragraph-start'?
> --
> Deniz Dogan
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-07-06 19:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4820D259.2060805@bbn.com>
[not found] ` <AANLkTill7PHyqYrJ8BWBN5nP_XLksHl9Dm0rPQvnE8b1@mail.gmail.com>
2010-07-06 19:29 ` bug#193: Alan Mackenzie
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).