From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Concerning the new `ido-use-virtual-buffers' feature Date: Fri, 28 May 2010 08:21:30 +0200 Message-ID: <201005280821.31181.tassilo@member.fsf.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1275027722 6757 80.91.229.12 (28 May 2010 06:22:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 28 May 2010 06:22:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 28 08:21:55 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OHsx5-0000X2-Tl for ged-emacs-devel@m.gmane.org; Fri, 28 May 2010 08:21:52 +0200 Original-Received: from localhost ([127.0.0.1]:46195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHsx4-0005zq-TP for ged-emacs-devel@m.gmane.org; Fri, 28 May 2010 02:21:50 -0400 Original-Received: from [140.186.70.92] (port=34534 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHswq-0005xf-Ch for emacs-devel@gnu.org; Fri, 28 May 2010 02:21:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHswo-0000kv-OW for emacs-devel@gnu.org; Fri, 28 May 2010 02:21:35 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:26323) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHswo-0000kS-DG for emacs-devel@gnu.org; Fri, 28 May 2010 02:21:34 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 42E8C78A46E6; Fri, 28 May 2010 08:21:33 +0200 (CEST) Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 09086-10; Fri, 28 May 2010 08:21:31 +0200 (CEST) X-CHKRCPT: Envelopesender noch tassilo@member.fsf.org Original-Received: from thinkpad.localnet (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTP id AD91178A46DF; Fri, 28 May 2010 08:21:31 +0200 (CEST) User-Agent: KMail/1.13.3 (Linux/2.6.34-gentoo; KDE/4.4.3; x86_64; ; ) In-Reply-To: X-Face: `TY6r/ws=N5uqO1E`M=Sups<}n%T[E^o_?MJj< =?iso-8859-1?q?O4j=265ljV6lU=7DcXU7oftH=26/x=5F=7EK=7B=26zv9=7D=0A=09sB?= =?iso-8859-1?q?=7D5/Ea=5BhU=7BCS=23=3F=3F0=3F=3Fn?=@sX+ft]?{(l?, mp"a`u List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125322 Archived-At: On Friday 28 May 2010 03:45:52 Leo wrote: Hi Leo, > > I slightly modified the patch and implemented the wishlist item. Cool! > > For buffers, if a let-bound variable can be added in > > ido-buffers-internal I usually avoid adding it in ido-read-internal. > > > > To remove virtual buffers as soon as input matches existing ones, the > > idea is to build a list of existing buffers (ignored buffers are not > > included) and then match the input against it in ido-exhibit. My > > testing is very brief though it seems working fine. Could you test it > > more thoroughly? Sure. > > Also remember to try the toggle virtual buffers key C-o too. Thanks. What do you mean with this one? > The can be changed > @@ -3427,7 +3431,9 @@ for first matching file." > (if default > (setq ido-temp-list > (cons default (delete default ido-temp-list)))) > - (if ido-use-virtual-buffers > + (if (or (eq ido-use-virtual-buffers 'always) > + (and (boundp ido-virtual-buffers-enabled) > + ido-virtual-buffers-enabled)) > (ido-add-virtual-buffers-to-list)) > (run-hooks 'ido-make-buffer-list-hook) > ido-temp-list)) > > > to: > > @@ -2736,7 +2739,8 @@ C-x C-f ... C-d enter `dired' on current directory." > See `ido-use-virtual-buffers' for explanation of virtual buffer." > (interactive) > (when (and ido-mode (eq ido-cur-item 'buffer)) > - (setq ido-use-virtual-buffers (not ido-use-virtual-buffers)) > + (setq ido-virtual-buffers-enabled > + (not ido-virtual-buffers-enabled)) > (setq ido-text-init ido-text) > (setq ido-exit 'refresh) > (exit-minibuffer))) Both of these hunks are in your patch. I've read your mail as if I could simply delete the @@ -3427,7 +3431,9 @@ part from your patch. I did that, but then 3 out of 10 hunks fail... And if I try to apply the original patch without these modifications, then 4 out of 11 hunks fail. Could you please compile a new patch agains the current bzr trunk that I can test? Bye, Tassilo