From: Noah Friedman <noah@splode.com>
To: emacs-devel@gnu.org
Subject: Re: setenv's broken case when value is nil
Date: Wed, 17 Feb 2010 18:02:16 -0800 (PST) [thread overview]
Message-ID: <20100217180216.661079.FMU4029@unexploded-cow.prv.splode.com> (raw)
In-Reply-To: 20100217175616.608022.FMU4029@unexploded-cow.prv.splode.com
>lorentey@elte.hu changed env.el on 2007-08-29 to define setenv-internal and
>for setenv always to keep the variable name in process-environment, even if
>value is nil. In other words, he removed the distinction between the empty
>string and nil, and therefore you can't remove variables from the
>environment using setenv anymore.
>
>Since all kinds of environment variables have meaning when they are
>defined, even if they are just set to the empty string, this is a screw.
My proposed change is this simple:
--- /export/src/emacs/build/2010-02-03--06-16-34--99438/lisp/env.el.~1~ 2010-02-17 18:00:41.968005373 -0800
+++ /export/src/emacs/build/2010-02-03--06-16-34--99438/lisp/env.el 2010-02-17 18:00:41.968005373 -0800
@@ -178,7 +178,7 @@
(if (string-equal "TZ" variable)
(set-time-zone-rule value))
(setq process-environment (setenv-internal process-environment
- variable value t))
+ variable value))
value)
(defun getenv (variable &optional frame)
next prev parent reply other threads:[~2010-02-18 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 1:56 setenv's broken case when value is nil Noah Friedman
2010-02-18 2:02 ` Noah Friedman [this message]
2010-02-18 15:38 ` Stefan Monnier
2010-02-18 4:12 ` Giorgos Keramidas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217180216.661079.FMU4029@unexploded-cow.prv.splode.com \
--to=noah@splode.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).