From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: (insert ?\n) spuriously calls before-change-functions twice. Help! Date: Tue, 19 Jan 2010 17:11:18 +0000 Message-ID: <20100119171118.GA2358@muc.de> References: <20100105110954.GA2639@muc.de> <20100105173158.GB2639@muc.de> <20100119132316.GA1171@muc.de> <87k4verux8.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263921182 25320 80.91.229.12 (19 Jan 2010 17:13:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jan 2010 17:13:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 19 18:12:55 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NXHdO-0002mY-Ef for ged-emacs-devel@m.gmane.org; Tue, 19 Jan 2010 18:12:54 +0100 Original-Received: from localhost ([127.0.0.1]:58092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXHdP-0000gW-84 for ged-emacs-devel@m.gmane.org; Tue, 19 Jan 2010 12:12:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXHVf-0005Dk-5m for emacs-devel@gnu.org; Tue, 19 Jan 2010 12:04:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXHVZ-0005BR-Ic for emacs-devel@gnu.org; Tue, 19 Jan 2010 12:04:53 -0500 Original-Received: from [199.232.76.173] (port=47292 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXHVZ-0005BH-0S for emacs-devel@gnu.org; Tue, 19 Jan 2010 12:04:49 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:1483 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXHVY-0003jH-9T for emacs-devel@gnu.org; Tue, 19 Jan 2010 12:04:48 -0500 Original-Received: (qmail 9398 invoked by uid 3782); 19 Jan 2010 17:04:45 -0000 Original-Received: from acm.muc.de (pD9E50663.dip.t-dialin.net [217.229.6.99]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Tue, 19 Jan 2010 18:04:43 +0100 Original-Received: (qmail 2617 invoked by uid 1000); 19 Jan 2010 17:11:18 -0000 Content-Disposition: inline In-Reply-To: <87k4verux8.fsf@stupidchicken.com> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:120236 Archived-At: Hi, Yidong, On Tue, Jan 19, 2010 at 10:11:47AM -0500, Chong Yidong wrote: > Alan Mackenzie writes: > >> > There doesn't seem to be any system in where the two change hooks are > >> > invoked. For example, insert directly calls signal_after_change, yet not > >> > signal_before_change; surely invocations of these should be paired. > >> Agreed. Patch very welcome, > > DONE. Specifically, revision 99376, fixing set_text_properties in > > textprop.c. > Please commit a ChangeLog entry as well. There is a ChangeLog entry, just that it's way down at 2010-01-08 (when I made the change on my own PC). I really ought to have "updated" it to show today's date, I think. With bzr, there's no longer a unique date of committing. I'll change this around to put my ChangeLog entry with and at today's date. Sorry for not thinking this through myself. -- Alan Mackenzie (Nuremberg, Germany).