From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: (insert ?\n) spuriously calls before-change-functions twice. Help!
Date: Tue, 19 Jan 2010 13:23:16 +0000 [thread overview]
Message-ID: <20100119132316.GA1171@muc.de> (raw)
In-Reply-To: <jwv1vi4l4ef.fsf-monnier+emacs@gnu.org>
Hi, Stefan!
On Tue, Jan 05, 2010 at 02:52:37PM -0500, Stefan Monnier wrote:
> > I think I've tracked down what's happening. After inserting the ?\n (any
> > other character is just the same), Emacs clears any text properties from
> > the new character by calling set_properties. This, in its turn, invokes
> > before-change-functions. A more detailed call stack is:
> Sounds like a bug indeed.
> > There doesn't seem to be any system in where the two change hooks are
> > invoked. For example, insert directly calls signal_after_change, yet not
> > signal_before_change; surely invocations of these should be paired.
> Agreed. Patch very welcome,
DONE. Specifically, revision 99376, fixing set_text_properties in
textprop.c.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2010-01-19 13:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 11:09 (insert ?\n) spuriously calls before-change-functions twice. Help! Alan Mackenzie
2010-01-05 15:22 ` Stefan Monnier
2010-01-05 17:31 ` Alan Mackenzie
2010-01-05 19:52 ` Stefan Monnier
2010-01-06 13:05 ` Alan Mackenzie
2010-01-06 14:33 ` Stefan Monnier
2010-01-19 13:23 ` Alan Mackenzie [this message]
2010-01-19 15:11 ` Chong Yidong
2010-01-19 17:11 ` Alan Mackenzie
2010-01-19 18:02 ` Chong Yidong
2010-01-19 22:30 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119132316.GA1171@muc.de \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).