unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: emacs-devel@gnu.org
Subject: Re: colours in client on xterm (if an X frame is open at same time)
Date: Fri, 8 Jan 2010 10:28:35 -0800 (PST)	[thread overview]
Message-ID: <201001081828.o08ISZgT016268@godzilla.ics.uci.edu> (raw)
In-Reply-To: <19271.23938.742044.640825@a1i15.kph.uni-mainz.de> (Ulrich Mueller's message of "Fri, 8 Jan 2010 17:29:54 +0100")

Ulrich Mueller <ulm@gentoo.org> writes:

  > >>>>> On Thu, 7 Jan 2010, Dan Nicolaescu wrote:
  > 
  > >> Anyway, my point was, why are the colours _different_ in the second
  > >> case? Especially, why is the background grey?
  > 
  > > It should not be.   I can't reproduce it here, but by emacs is about
  > > 2 weeks old.
  > 
  > > In the grey case, do you get something odd if you do a describe-face
  > > for the default face?
  > 
  > Differences between normal and grey case are:
  > 
  >    -    Foreground: unspecified-fg
  >    -    Background: unspecified-bg
  >    +    Foreground: black
  >    +    Background: white
  > 
  >    -          Font: unspecified
  >    -       Fontset: nil
  >    +          Font: #<font-spec nil nil nil nil nil nil nil nil nil nil nil nil ((user-spec . monospace-12))>
  >    +       Fontset: -unknown-DejaVu Sans Mono-normal-normal-normal-*-13-*-*-*-m-0-fontset-startup
  > 
  > > Is this something new? Do you get the same behavior with 23.1?
  > > If not, then doing a binary search for the patch that broke it is your
  > > best bet...
  > 
  > I had hoped that the bisecting could be avoided, but here we go.
  > 
  > The "grey background" started with revision 99013 (and reverting this
  > changeset in the trunk of today brings back the old behaviour):
  > 
  >    revno: 99013
  >    committer: Dan Nicolaescu <dann@ics.uci.edu>
  >    branch nick: trunk
  >    timestamp: Mon 2009-12-07 06:30:30 +0000
  >    message:
  >      Get the background mode from the terminal for xterm, and set
  >      faces accordingly.
  >      * term/xterm.el (xterm-set-background-mode): New function.
  >      (terminal-init-xterm): Use it in case xterm supports background
  >      color queries.  Recompute faces after getting the background
  >      color.

Thanks.

In your case the only effect that patch should have is to move the call
 (tty-set-up-initial-frame-faces) from before

(let ((coding-system-for-read 'binary)

to after it.

What happens in that `let' should not matter to your setup because your
background is light, so change 99013 should be a no-op in your case.

Hmmm, this is very odd...






  reply	other threads:[~2010-01-08 18:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 23:26 colours in client on xterm (if an X frame is open at same time) Ulrich Mueller
2010-01-07 23:58 ` Dan Nicolaescu
2010-01-08  6:43   ` Ulrich Mueller
2010-01-08  7:13     ` Dan Nicolaescu
2010-01-08 16:29       ` Ulrich Mueller
2010-01-08 18:28         ` Dan Nicolaescu [this message]
2010-01-08 22:31           ` Ulrich Mueller
     [not found]           ` <201001090418.o094Iw6d007997@godzilla.ics.uci.edu>
2010-01-09  7:55             ` Eli Zaretskii
2010-01-10  8:49               ` Dan Nicolaescu
2010-01-10 18:03                 ` Eli Zaretskii
2010-01-10 18:32                   ` Dan Nicolaescu
2010-01-08  7:47     ` Jan Djärv
2010-01-08 16:48       ` Dan Nicolaescu
2010-01-08  3:02 ` Eric Hanchrow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001081828.o08ISZgT016268@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).