From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: bug#881: patch for bug #881 Date: Wed, 6 Jan 2010 10:29:00 -0800 (PST) Message-ID: <201001061829.o06IT0Zm002189@godzilla.ics.uci.edu> References: <87wrzwp5gd.fsf@stupidchicken.com> <201001060700.o06706Sw006855@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1262802671 2931 80.91.229.12 (6 Jan 2010 18:31:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Jan 2010 18:31:11 +0000 (UTC) Cc: Juanma Barranquero , Chong Yidong , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 06 19:31:03 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NSaes-0007rX-VC for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2010 19:31:03 +0100 Original-Received: from localhost ([127.0.0.1]:37114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSaet-0003QU-9L for ged-emacs-devel@m.gmane.org; Wed, 06 Jan 2010 13:31:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NSaek-0003JX-Uy for emacs-devel@gnu.org; Wed, 06 Jan 2010 13:30:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NSaeg-0003A0-OY for emacs-devel@gnu.org; Wed, 06 Jan 2010 13:30:54 -0500 Original-Received: from [199.232.76.173] (port=56210 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NSaeg-00039b-Ib for emacs-devel@gnu.org; Wed, 06 Jan 2010 13:30:50 -0500 Original-Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:39696) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NSaeg-0005ov-39 for emacs-devel@gnu.org; Wed, 06 Jan 2010 13:30:50 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id o06IT0SA001172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Jan 2010 10:29:00 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id o06IT0Zm002189; Wed, 6 Jan 2010 10:29:00 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 06 Jan 2010 09:20:04 -0500") Original-Lines: 33 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: o06IT0SA001172 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119535 Archived-At: Stefan Monnier writes: > > How should it work? We don't have any nice generic mechanism/UI for > > doing VC backend specific things in the commit buffer. > > It's a general concept, although it's not supported by all backends. The general concept is that backends want to do backend specific things :-) For example git might want to add "--signoff" Or might want to add "--amend", in which case the log for the latest commit should be inserted in the log-edit buffer for further editing. > I'd imagine some log-edit-mode command that set log-edit-author and is > then somehow passed to VC via the log-edit-callback which then passes it > to the backend as an additional argument to the `commit' operation. > > Maybe the easiest way is to store the info directly in the text in the > form of a "Author: ..." line somewhere. > > Along similar lines, we'd like a way to pass the "--fixes" arg to Bzr, > so maybe we should let log-edit-mode use a buffer in a RFC822-like format, > where backends may recognize some headers ("Subject", "Author", > "Fixes", ...) and discard others. This would be helpful, but not enough, we also want to have some key bindings, menu entries for backend specific things. So how about starting by replacing the call to `log-edit' in `vc-log-edit' with (vc-call-backend backend 'log-edit) and then each backend that so desires can implement a mode derived from log-edit and do whatever it wants (like we do for log-view).