vc-log bug?

vc-log bug?

[Giorgos Keramidas]

Some of the recent VC changes broke vc-log for Mercurial here.  My HOME
directory now has less than 2000 changesets:

  changeset:   789:943233c01bf5
  tag:         tip
  user:        Giorgos Keramidas <keramida@ceid.upatras.gr>
  date:        Mon Dec 14 08:49:03 2009 +0200
  summary:     agenda: update clock/time table for today's work

but when I type `C-x v l' the latest VC code tries to see the log of
changes 2000:tip.  Since there is no revision numbered 2000 vc stops
with a backtrace of:

: Debugger entered--Lisp error: (error "Running hg log -r2000:
: AGENDA...FAILED (status 255)")
:   signal(error ("Running hg log -r2000: AGENDA...FAILED (status 255)"))
:   error("Running %s...FAILED (%s)" "hg log -r2000: AGENDA" "status 255")
:   vc-do-command("*vc-change-log*" 0 "hg" ("/home/keramida/AGENDA") "log"  "-r2000:")
:   apply(vc-do-command "*vc-change-log*" 0 "hg" ("/home/keramida/AGENDA") ("log" "-r2000:"))
:   vc-hg-command("*vc-change-log*" 0 ("/home/keramida/AGENDA") "log" "-r2000:")
:   apply(vc-hg-command "*vc-change-log*" 0 ("/home/keramida/AGENDA") "log" "-r2000:")
:   vc-hg-print-log(("/home/keramida/AGENDA") "*vc-change-log*" nil nil 2000)
:   apply(vc-hg-print-log (("/home/keramida/AGENDA") "*vc-change-log*" nil nil 2000))
:   vc-call-backend(Hg print-log ("/home/keramida/AGENDA") "*vc-change-log*" nil nil 2000)
:   vc-print-log-internal(Hg ("/home/keramida/AGENDA") "789" nil 2000)
:   vc-print-log(nil 2000)
:   call-interactively(vc-print-log nil nil)

Is there any way to tweak the limit automatically to, say, half of the
revisions in the current repository?

Re: vc-log bug?

[Dan Nicolaescu]

Giorgos Keramidas <keramida@ceid.upatras.gr> writes:

  > Some of the recent VC changes broke vc-log for Mercurial here.  My HOME
  > directory now has less than 2000 changesets:
  > 
  >   changeset:   789:943233c01bf5
  >   tag:         tip
  >   user:        Giorgos Keramidas <keramida@ceid.upatras.gr>
  >   date:        Mon Dec 14 08:49:03 2009 +0200
  >   summary:     agenda: update clock/time table for today's work
  > 
  > but when I type `C-x v l' the latest VC code tries to see the log of
  > changes 2000:tip.

Thanks.  This is a bug in vc-hg.el.  Fixed like this:

--- vc-hg.el.~1.108.~  2009-12-07 00:53:20.000000000 -0800
+++ vc-hg.el           2009-12-14 07:56:11.000000000 -0800
@@ -223,7 +223,7 @@ If nil, use the value of `vc-diff-switch
                  (repeat :tag "Argument List" :value ("") string))
   :group 'vc-hg)
 
-(defun vc-hg-print-log (files buffer &optional shortlog limit start-revision)
+(defun vc-hg-print-log (files buffer &optional shortlog start-revision limit)
   "Get change log associated with FILES."
   ;; `vc-do-command' creates the buffer, but we need it before running
   ;; the command.

Re: vc-log bug?

[Giorgos Keramidas]

On Mon, 14 Dec 2009 08:05:06 -0800 (PST), Dan Nicolaescu <dann@ics.uci.edu> wrote:
> Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
>
>   > Some of the recent VC changes broke vc-log for Mercurial here.  My HOME
>   > directory now has less than 2000 changesets:
>   >
>   >   changeset:   789:943233c01bf5
>   >   tag:         tip
>   >   user:        Giorgos Keramidas <keramida@ceid.upatras.gr>
>   >   date:        Mon Dec 14 08:49:03 2009 +0200
>   >   summary:     agenda: update clock/time table for today's work
>   >
>   > but when I type `C-x v l' the latest VC code tries to see the log of
>   > changes 2000:tip.
>
> Thanks.  This is a bug in vc-hg.el.  Fixed like this:
>
> --- vc-hg.el.~1.108.~  2009-12-07 00:53:20.000000000 -0800
> +++ vc-hg.el           2009-12-14 07:56:11.000000000 -0800
> @@ -223,7 +223,7 @@ If nil, use the value of `vc-diff-switch
>                   (repeat :tag "Argument List" :value ("") string))
>    :group 'vc-hg)
>
> -(defun vc-hg-print-log (files buffer &optional shortlog limit start-revision)
> +(defun vc-hg-print-log (files buffer &optional shortlog start-revision limit)
>    "Get change log associated with FILES."
>    ;; `vc-do-command' creates the buffer, but we need it before running
>    ;; the command.

Excellent!  I'll rebuild with this patch and let you know :)

Re: vc-log bug?

[Giorgos Keramidas]

On Mon, 14 Dec 2009 18:52:51 +0200, Giorgos Keramidas <keramida@ceid.upatras.gr> wrote:
>On Mon, 14 Dec 2009 08:05:06 -0800 (PST), Dan Nicolaescu <dann@ics.uci.edu> wrote:
>>Giorgos Keramidas <keramida@ceid.upatras.gr> writes:
>>> Some of the recent VC changes broke vc-log for Mercurial here.  My HOME
>>> directory now has less than 2000 changesets:
>>>
>>>   changeset:   789:943233c01bf5
>>>   tag:         tip
>>>   user:        Giorgos Keramidas <keramida@ceid.upatras.gr>
>>>   date:        Mon Dec 14 08:49:03 2009 +0200
>>>   summary:     agenda: update clock/time table for today's work
>>>
>>> but when I type `C-x v l' the latest VC code tries to see the log of
>>> changes 2000:tip.
>>
>> Thanks.  This is a bug in vc-hg.el.  Fixed like this:
>>
>> --- vc-hg.el.~1.108.~  2009-12-07 00:53:20.000000000 -0800
>> +++ vc-hg.el           2009-12-14 07:56:11.000000000 -0800
>> @@ -223,7 +223,7 @@ If nil, use the value of `vc-diff-switch
>>                   (repeat :tag "Argument List" :value ("") string))
>>    :group 'vc-hg)
>>
>> -(defun vc-hg-print-log (files buffer &optional shortlog limit start-revision)
>> +(defun vc-hg-print-log (files buffer &optional shortlog start-revision limit)
>>    "Get change log associated with FILES."
>>    ;; `vc-do-command' creates the buffer, but we need it before running
>>    ;; the command.
>
> Excellent!  I'll rebuild with this patch and let you know :)

Fixed, indeed.