From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Kifer Newsgroups: gmane.emacs.devel Subject: Re: Ediff-patch-file with wrong default buffer (was: Fix info display of images) Date: Mon, 14 Dec 2009 00:43:25 -0500 Organization: Stony Brook University Message-ID: <20091214004325.61e9afe3@kiferserv> References: <874oo5nfsl.fsf@lola.goethe.zz> <87ljhey8gx.fsf@mail.jurta.org> <874oo2jzq2.fsf@lola.goethe.zz> <87aaxnjfkg.fsf@lola.goethe.zz> <87pr6iskww.fsf@mail.jurta.org> <87eimytcl1.fsf@stupidchicken.com> <87ocm2p1vf.fsf_-_@mail.jurta.org> Reply-To: kifer@cs.sunysb.edu NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1260769439 26544 80.91.229.12 (14 Dec 2009 05:43:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Dec 2009 05:43:59 +0000 (UTC) Cc: Chong Yidong , David Kastrup , Michael Kifer , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 14 06:43:50 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NK3im-0007Vs-V2 for ged-emacs-devel@m.gmane.org; Mon, 14 Dec 2009 06:43:49 +0100 Original-Received: from localhost ([127.0.0.1]:44229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK3im-00089t-HG for ged-emacs-devel@m.gmane.org; Mon, 14 Dec 2009 00:43:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NK3ie-00089D-Ih for emacs-devel@gnu.org; Mon, 14 Dec 2009 00:43:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NK3iZ-00087C-7J for emacs-devel@gnu.org; Mon, 14 Dec 2009 00:43:39 -0500 Original-Received: from [199.232.76.173] (port=42974 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK3iZ-000879-2K for emacs-devel@gnu.org; Mon, 14 Dec 2009 00:43:35 -0500 Original-Received: from sbcs.cs.sunysb.edu ([130.245.1.15]:59669) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NK3iW-0000NX-U5; Mon, 14 Dec 2009 00:43:33 -0500 Original-Received: from kiferserv (compserv2 [130.245.1.58]) by sbcs.cs.sunysb.edu (8.13.6/8.12.11) with ESMTP id nBE5hMwm005300; Mon, 14 Dec 2009 00:43:23 -0500 (EST) In-Reply-To: <87ocm2p1vf.fsf_-_@mail.jurta.org> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.1; i486-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118606 Archived-At: On Mon, 14 Dec 2009 07:14:12 +0200 Juri Linkov wrote: > >> This is not just improvement, but a plain bug fix. I suggest to > >> install it. > >> > >> Since IIUC currently CVS is read-only, you could create a bug report > >> in the bug database to guarantee your bug fix is not lost and fixed in > >> the next release. > > > > It is not read-only yet, I think. Please go ahead and install the > > patch. > > Installed. > > BTW, there is some regression in Ediff. > > Running `ediff-patch-file' in a buffer with the patch used to propose > the name of the current buffer by default, but now it proposes some > irrelevant buffer name. > > This bug can be reproduced by opening the initial David's message with the > patch in this thread and typing `M-x ediff-patch-file'. To the question > "Is the patch already in a buffer" type `y'. After that in the prompt > "Buffer that holds the patch" it provides some other buffer by default. > It used to provide the current buffer by default. > > Maybe the reason is that Ediff recognizes buffers with patches only > in the CVS format? In this case Ediff should be fixed to support > other formats since we are switching from CVS now. I haven't looked at the ediff patch, which you are referring to, but, FYI, Ediff only looks at the current buffer, the next, and the previous, window, and the other-buffer. It does not attempt to search for the best possible buffer. In those buffers that it looks at, it tries to see if it has a diff or a context diff. This is controlled by ediff-context-diff-label-regexp. So, either the patch that you are referring to broke the above behavior or the current buffer does not match ediff-context-diff-label-regexp.