From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: vc-git bug in vc-dir Date: Tue, 1 Dec 2009 12:53:20 -0800 (PST) Message-ID: <200912012053.nB1KrKEg028043@godzilla.ics.uci.edu> References: <200912011954.nB1JsDW6027606@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259700918 14226 80.91.229.12 (1 Dec 2009 20:55:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Dec 2009 20:55:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 01 21:55:11 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NFZkc-0005Yj-3a for ged-emacs-devel@m.gmane.org; Tue, 01 Dec 2009 21:55:10 +0100 Original-Received: from localhost ([127.0.0.1]:58921 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFZkb-0001eC-Oe for ged-emacs-devel@m.gmane.org; Tue, 01 Dec 2009 15:55:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFZkW-0001bx-9o for emacs-devel@gnu.org; Tue, 01 Dec 2009 15:55:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFZkQ-0001WW-Jy for emacs-devel@gnu.org; Tue, 01 Dec 2009 15:55:02 -0500 Original-Received: from [199.232.76.173] (port=37383 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFZkQ-0001WL-CW for emacs-devel@gnu.org; Tue, 01 Dec 2009 15:54:58 -0500 Original-Received: from paul-mcgann-v0.ics.uci.edu ([128.195.1.147]:43159) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFZkQ-0007bm-2J for emacs-devel@gnu.org; Tue, 01 Dec 2009 15:54:58 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by paul-mcgann-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nB1KrLv5025584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 1 Dec 2009 12:53:21 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nB1KrKEg028043; Tue, 1 Dec 2009 12:53:20 -0800 (PST) In-Reply-To: (Tom Tromey's message of "Tue, 01 Dec 2009 13:27:38 -0700") Original-Lines: 21 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nB1KrLv5025584 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118067 Archived-At: Tom Tromey writes: > >>>>> "Dan" == Dan Nicolaescu writes: > > Dan> Eric Hanchrow posted a patch in Bug#1589 that fixes this by using a > Dan> git option available in git after version 1.5.5 (which > Dan> was released in April 2008) > > Dan> Should we check in this fix? > > Dan> What do git users think? > > It seems to me that if it fails nicely with older versions of git -- > saying what the problem is and how to work around it -- then the patch > should definitely go in. It does not fail nicely. So there's a trade off: vc-dir fails with old versions (we can document that in NEWS), or it fails all the time (as it currently does). IMHO dealing nicely with old version is not worth the effort and added code gunk (plus volunteers to do it are hard to find).