From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: garbage-collect not called for .el files in loadup.el Date: Tue, 3 Nov 2009 20:13:50 -0800 (PST) Message-ID: <200911040413.nA44Do0r028213@godzilla.ics.uci.edu> References: <200911040200.nA420mRf027254@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257308148 16183 80.91.229.12 (4 Nov 2009 04:15:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Nov 2009 04:15:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 04 05:15:41 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N5XHW-0008Bu-MB for ged-emacs-devel@m.gmane.org; Wed, 04 Nov 2009 05:15:38 +0100 Original-Received: from localhost ([127.0.0.1]:55105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5XHW-0000lZ-4R for ged-emacs-devel@m.gmane.org; Tue, 03 Nov 2009 23:15:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5XHQ-0000lT-GA for emacs-devel@gnu.org; Tue, 03 Nov 2009 23:15:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5XHL-0000fi-K6 for emacs-devel@gnu.org; Tue, 03 Nov 2009 23:15:31 -0500 Original-Received: from [199.232.76.173] (port=41861 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5XHL-0000fZ-EX for emacs-devel@gnu.org; Tue, 03 Nov 2009 23:15:27 -0500 Original-Received: from colin-baker-v0.ics.uci.edu ([128.195.1.153]:57384) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N5XHK-0002dC-SX for emacs-devel@gnu.org; Tue, 03 Nov 2009 23:15:27 -0500 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nA44DoA2013027 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Nov 2009 20:13:51 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nA44Do0r028213; Tue, 3 Nov 2009 20:13:50 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Tue, 03 Nov 2009 22:47:37 -0500") Original-Lines: 33 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nA44DoA2013027 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116614 Archived-At: Stefan Monnier writes: > > As the subject says, GC is not done after loading .el files in > > loadup.el, only .elc files. > > What difference does it make in practice? More garbage is produced before gc, so the memory layout is worse. > > - (unless purify-flag > > + (if purify-flag > > + (run-hook-with-args 'after-load-functions fullname) > > (do-after-load-evaluation fullname)) > > Nope, sorry, that's ugly. You can simply remove the `unless > purify-flag' on the other hand, since Fload calls > do-after-load-evaluation unconditionally. Not when using `load-source-file-function': /* We are loading a source file (*.el). */ if (!NILP (Vload_source_file_function)) { Lisp_Object val; if (fd >= 0) emacs_close (fd); val = call4 (Vload_source_file_function, found, hist_file_name, NILP (noerror) ? Qnil : Qt, (NILP (nomessage) || force_load_messages) ? Qnil : Qt); return unbind_to (count, val); }