unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Andreas Schwab <schwab@linux-m68k.org>,
	emacs-devel@gnu.org
Subject: defcustom standard-value (was: Re: BASE_PURESIZE)
Date: Thu, 29 Oct 2009 18:17:18 -0700 (PDT)	[thread overview]
Message-ID: <200910300117.n9U1HIgs014051@godzilla.ics.uci.edu> (raw)
In-Reply-To: <200910250824.n9P8OlUp013541@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 25 Oct 2009 01:24:47 -0700 (PDT)")

Dan Nicolaescu <dann@ics.uci.edu> writes:

  > Another issue that I hit:
  > 
  > Changing (in files.el)
  > 
  > From:
  > (defcustom directory-free-space-program "df"
  > to:
  > (defcustom directory-free-space-program (purecopy "df")
  > 
  > does not get rid of the "df" string in GC memory.  The reason is
  > 
  > ELISP> (get 'directory-free-space-program 'standard-value)
  > ((purecopy "df"))
  > 
  > BTW, this is not a problem for autoloaded defcustoms, they get
  > transformed into defvars in loaddefs.el.

Is this patch TRTD?

Index: lisp/custom.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/custom.el,v
retrieving revision 1.149
diff -u -3 -p -r1.149 custom.el
--- lisp/custom.el    15 Sep 2009 04:08:04 -0000        1.149
+++ lisp/custom.el    29 Oct 2009 07:50:00 -0000
@@ -131,7 +131,7 @@ not the default value itself.
 DEFAULT is stored as SYMBOL's standard value, in SYMBOL's property
 `standard-value'.  At the same time, SYMBOL's property `force-value' is
 set to nil, as the value is no longer rogue."
-  (put symbol 'standard-value (list default))
+  (put symbol 'standard-value (purecopy (list default)))
   ;; Maybe this option was rogue in an earlier version.  It no longer is.
   (when (get symbol 'force-value)
     (put symbol 'force-value nil))




  reply	other threads:[~2009-10-30  1:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23 11:00 BASE_PURESIZE Eli Zaretskii
2009-10-23 11:39 ` BASE_PURESIZE Andreas Schwab
2009-10-23 14:10   ` BASE_PURESIZE Eli Zaretskii
2009-10-23 14:24     ` BASE_PURESIZE Andreas Schwab
2009-10-23 14:35       ` BASE_PURESIZE Eli Zaretskii
2009-10-23 14:50         ` BASE_PURESIZE Andreas Schwab
2009-10-24 10:05     ` BASE_PURESIZE Eli Zaretskii
2009-10-24 10:37       ` BASE_PURESIZE Andreas Schwab
2009-10-24 13:18         ` BASE_PURESIZE Eli Zaretskii
2009-10-24 17:27           ` BASE_PURESIZE Dan Nicolaescu
2009-10-24 19:01             ` BASE_PURESIZE Stefan Monnier
2009-10-25  8:24               ` BASE_PURESIZE Dan Nicolaescu
2009-10-30  1:17                 ` Dan Nicolaescu [this message]
2009-10-24 19:04             ` BASE_PURESIZE Chong Yidong
2009-10-24 19:16               ` BASE_PURESIZE Dan Nicolaescu
2009-10-23 11:58 ` BASE_PURESIZE Dan Nicolaescu
2009-10-23 14:24 ` BASE_PURESIZE Juanma Barranquero
2009-10-24  4:41   ` BASE_PURESIZE Stephen J. Turnbull
2009-10-24  6:47     ` BASE_PURESIZE Dan Nicolaescu
2009-10-24  8:24       ` BASE_PURESIZE Stephen J. Turnbull
2009-10-24 10:22     ` BASE_PURESIZE Eli Zaretskii
2009-10-24 11:14       ` BASE_PURESIZE Stephen J. Turnbull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910300117.n9U1HIgs014051@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).