unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: allow C-x v i / C-x v v to create a repository if none is available
Date: Fri, 9 Oct 2009 12:32:59 -0700 (PDT)	[thread overview]
Message-ID: <200910091932.n99JWxeG000686@godzilla.ics.uci.edu> (raw)
In-Reply-To: <jwvab00gz1x.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 09 Oct 2009 15:18:15 -0400")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

  > > When doing C-x v i or C-x v v on an unregistered file that is in a
  > > directory not under any version control, the file will be registered
  > > with RCS.  That is not exactly what most users want.
  > 
  > Very good point.  In the past, there wasn't much choice anyway since
  > creating a CVS repository required a lot more work, but indeed, with
  > current DVCS such a behavior makes sense again.
  > 
  > Now, most relevant backends will also want to know where you want to put
  > the root of your new repository.  Should we let the backend function
  > `create-repo' prompt for this, or should we move it to the generic part
  > of the code?  You seem to have taken the first choice, whereas I'd lean
  > towards the second.

I just took smallest patch path :-), just create the repository in the
current directory.

Do we have any backend specific function that are required to prompt?
I don't think we do.

So I'd say that for consistency it would be better to prompt in the
generic code.  This also avoid the code duplication in all backends.

What's your reasoning for leaning towards the second?




  reply	other threads:[~2009-10-09 19:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 20:47 allow C-x v i / C-x v v to create a repository if none is available Dan Nicolaescu
2009-10-08 21:10 ` Chong Yidong
2009-10-09 19:18 ` Stefan Monnier
2009-10-09 19:32   ` Dan Nicolaescu [this message]
2009-10-13 18:40     ` Stefan Monnier
2009-10-13 15:59   ` Dan Nicolaescu
2009-10-21 19:06   ` Dan Nicolaescu
2009-10-23  7:45     ` Dan Nicolaescu
2009-10-23 13:12       ` Stefan Monnier
2009-10-24  2:34       ` Miles Bader
2009-10-24  6:35         ` Dan Nicolaescu
2009-10-22 18:56   ` Code for converting between Elisp and Calc floats Jay Belanger
2009-10-22 20:04     ` James Cloos
2009-10-23  0:50     ` Stefan Monnier
2009-10-24 20:03       ` Jay Belanger
2009-10-25  0:56         ` Stefan Monnier
2009-10-25  5:36           ` David Kastrup
2009-10-25 11:36             ` Vincent Belaïche
2009-10-25 14:11               ` Chong Yidong
2009-10-25 19:29                 ` Vincent Belaïche
2009-10-26  2:30                   ` Stefan Monnier
2009-10-26 12:48                     ` Vincent Belaïche
2009-10-27  3:22                       ` Stefan Monnier
2009-10-25 13:57             ` Stefan Monnier
2009-10-25 18:35               ` Eli Zaretskii
2009-10-26  2:02                 ` Large files (was: Code for converting between Elisp and Calc floats) Stefan Monnier
2009-10-23 13:11     ` Code for converting between Elisp and Calc floats Richard Stallman
2009-10-23 13:26       ` David Kastrup
2009-10-24 17:34         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910091932.n99JWxeG000686@godzilla.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).