From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] term.el make bold face customizable Date: Wed, 23 Sep 2009 09:41:46 -0700 (PDT) Message-ID: <200909231641.n8NGfksd028683@godzilla.ics.uci.edu> References: <86ocp1hkd1.fsf@kanis.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253724235 7170 80.91.229.12 (23 Sep 2009 16:43:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Sep 2009 16:43:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ivan Kanis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 23 18:43:47 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MqUwL-0000GE-1T for ged-emacs-devel@m.gmane.org; Wed, 23 Sep 2009 18:43:37 +0200 Original-Received: from localhost ([127.0.0.1]:35136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqUwK-000663-GJ for ged-emacs-devel@m.gmane.org; Wed, 23 Sep 2009 12:43:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqUwE-00065Z-AS for emacs-devel@gnu.org; Wed, 23 Sep 2009 12:43:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqUwA-000650-OY for emacs-devel@gnu.org; Wed, 23 Sep 2009 12:43:30 -0400 Original-Received: from [199.232.76.173] (port=35403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqUwA-00064w-FZ for emacs-devel@gnu.org; Wed, 23 Sep 2009 12:43:26 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:44578) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MqUw9-0004l1-QC for emacs-devel@gnu.org; Wed, 23 Sep 2009 12:43:26 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8NGflEo018459; Wed, 23 Sep 2009 09:41:47 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8NGfksd028683; Wed, 23 Sep 2009 09:41:46 -0700 (PDT) In-Reply-To: <86ocp1hkd1.fsf@kanis.fr> (Ivan Kanis's message of "Wed, 23 Sep 2009 15:16:26 +0200") Original-Lines: 56 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8NGflEo018459 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-0.34, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FM_MULTI_ODD2 1.10) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115554 Archived-At: Ivan Kanis writes: > Hi Dan, > > Could you apply the following trivial patch? I am against this kind of stuff. Next we will have to add a way customize something so that to not display the blue color for example? You can modify the terminfo/termcap entry locally to not say that bold is supported, then well behaved applications will not display bold. You might want to try to convince Stefan to apply it. > Kind regards, > -- > Ivan > Kanis http://kanis.fr > > If you want others to be happy, practice compassion. > If you want to be happy, practice compassion. > -- Dalai Lama > > --- tmp/term.el 2009-09-23 15:04:37.000000000 +0200 > +++ hg/lisp/misc/term.el 2009-09-23 15:10:06.000000000 +0200 > @@ -482,6 +482,9 @@ > :type '(choice (const nil) file) > :group 'term) > > +(defvar term-bold-attribute '(:weight bold) > + "Set to '(:weight normal) to disable bold") > + > (defvar term-prompt-regexp "^" > "Regexp to recognize prompts in the inferior process. > Defaults to \"^\", the null string at BOL. > @@ -3228,8 +3231,8 @@ > term-default-bg-color > (elt ansi-term-color-vector term-ansi-current-bg-color)))) > (when term-ansi-current-bold > - (setq term-current-face > - (append '(:weight bold) term-current-face))) > + (setq term-current-face > + (append term-bold-attribute term-current-face))) > (when term-ansi-current-underline > (setq term-current-face > (append '(:underline t) term-current-face)))) > @@ -3257,7 +3260,7 @@ > (elt ansi-term-color-vector term-ansi-current-bg-color)))) > (when term-ansi-current-bold > (setq term-current-face > - (append '(:weight bold) term-current-face))) > + (append term-bold-attribute term-current-face))) > (when term-ansi-current-underline > (setq term-current-face > (append '(:underline t) term-current-face))))))