From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: improve vc-bzr-print-log Date: Thu, 13 Aug 2009 10:40:47 -0700 (PDT) Message-ID: <200908131740.n7DHelPw016695@godzilla.ics.uci.edu> References: <200907261728.n6QHSNCP010388@godzilla.ics.uci.edu> <87y6qbutg4.fsf@stupidchicken.com> <200907262155.n6QLtQk4013442@godzilla.ics.uci.edu> <87k51762t6.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1250185383 14796 80.91.229.12 (13 Aug 2009 17:43:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Aug 2009 17:43:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 13 19:42:56 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MbeK5-0007A4-TX for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2009 19:42:46 +0200 Original-Received: from localhost ([127.0.0.1]:35582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbeK5-0006OH-Fc for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2009 13:42:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbeK1-0006NX-8J for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:42:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbeJw-0006N6-31 for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:42:40 -0400 Original-Received: from [199.232.76.173] (port=51542 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbeJv-0006N3-UW for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:42:35 -0400 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:33721) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MbeJv-0007ae-DT for emacs-devel@gnu.org; Thu, 13 Aug 2009 13:42:35 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n7DHemfq028559; Thu, 13 Aug 2009 10:40:48 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n7DHelPw016695; Thu, 13 Aug 2009 10:40:47 -0700 (PDT) In-Reply-To: <87k51762t6.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 13 Aug 2009 13:28:37 -0400") Original-Lines: 39 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n7DHemfq028559 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114193 Archived-At: Chong Yidong writes: > Dan Nicolaescu writes: > > > Chong Yidong writes: > > > > > Dan Nicolaescu writes: > > > > > > > When vc-bzr was written "bzr log" did not take multiple file arguments, > > > > it does now, so vc-bzr-print-log can take advantage of this. > > > > > > > > Any objection to this patch? > > > > > > How old are the versions of bzr that don't accept multiple file > > > arguments, > > > > No idea, I only have access to bzr-1.16.1. > > > > > and what effect does this change have on those versions? > > > > Doing C-x v l when multiple files are selected in vc-dir will not work. > > C-x v l from a file context will work just the same. > > The thing is that bzr users have all the reasons to use very up to date > > versions, the performance and disk usage is dramatically better. > > C-x v l for multiple files is new in 23.1, so not supporting it for old > > bzr versions in 23.2 does not seem like a problem. > > Sorry for coming back to this so late. > > Could you add a defcustom to toggle between this new code (giving > multiple file arguments to "bzr log") and the old code, defaulting to > the new code? I don't think it's worth trying to autodetect bzr > version, but let's at least give users a way to get the old behavior if > they need it. Stefan already approved the change as I proposed it. Personally I am against adding such a toggle, it's just an unnecessary complication given that we have no supporting evidence that anyone actually wants it.