From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Darkening font-lock colors Date: Mon, 3 Aug 2009 05:34:20 -0700 (PDT) Message-ID: <200908031234.n73CYKlg013580@godzilla.ics.uci.edu> References: <87d47hoox5.fsf@stupidchicken.com> <200907302139.n6ULdKCr008497@godzilla.ics.uci.edu> <87my6lrfzf.fsf@stupidchicken.com> <200907302221.n6UMLUWZ009001@godzilla.ics.uci.edu> <87hbwtisco.fsf@cyd.mit.edu> <200907310239.n6V2dFGY012065@godzilla.ics.uci.edu> <87iqh5ivn4.fsf@mail.jurta.org> <200908030344.n733iceT009655@godzilla.ics.uci.edu> <87skg9yw2v.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1249303084 10486 80.91.229.12 (3 Aug 2009 12:38:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Aug 2009 12:38:04 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 03 14:37:56 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MXwnZ-00072t-ON for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2009 14:37:54 +0200 Original-Received: from localhost ([127.0.0.1]:52556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXwnZ-00045j-7s for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2009 08:37:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MXwnU-00044V-Ad for emacs-devel@gnu.org; Mon, 03 Aug 2009 08:37:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MXwnP-0003zH-CW for emacs-devel@gnu.org; Mon, 03 Aug 2009 08:37:47 -0400 Original-Received: from [199.232.76.173] (port=46293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MXwnP-0003zA-4q for emacs-devel@gnu.org; Mon, 03 Aug 2009 08:37:43 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:40806) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MXwnO-0003H2-FI for emacs-devel@gnu.org; Mon, 03 Aug 2009 08:37:42 -0400 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MXwlv-0002Z6-At for emacs-devel@gnu.org; Mon, 03 Aug 2009 08:36:11 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n73CYL4a020469; Mon, 3 Aug 2009 05:34:21 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n73CYKlg013580; Mon, 3 Aug 2009 05:34:20 -0700 (PDT) In-Reply-To: <87skg9yw2v.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 03 Aug 2009 12:59:28 +0300") Original-Lines: 31 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n73CYL4a020469 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-Detected-Operating-System: by mx20.gnu.org: Solaris 10 (beta) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113604 Archived-At: Juri Linkov writes: > > > > Given that you are changing faces, how about changing the dark > > > > background, 8 color font-lock-comment-face to "yellow", then we can > > > > obsolete `font-lock-comment-delimiter-face'. > > > > > > Why yellow? > > > > It has good contrast with the black background and it is only used by > > font-lock-variable-face on an 8 color dark background terminal. > > Then yellow would be good for font-lock-comment-face, but I think > font-lock-comment-delimiter should stay in red. Why? font-lock-comment-delimiter is a hack. And an unnecessary complication. It was only introduced because the red foreground used on an 8 color dark background terminal was not readable. font-lock-comment-delimiter it is currently only used for 8 color dark background terminals. The problem is that this is confusing for users: we got many bug reports about syntax coloring not working because the users saw the body of the comments not being syntax highlighted. Distributions (Debian, Ubuntu and probably others too) patched this out by using red for font-lock-comment-face, effectively defeating the purpose of why font-lock-comment-delimiter was introduced. So I am proposing to simplify this whole thing by removing the reason for font-lock-comment-delimiter to exist: use a readable yellow foreground on 8 color dark background terminals.