From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: show whitespace problems by default in diff-mode Date: Thu, 16 Jul 2009 18:37:33 -0700 (PDT) Message-ID: <200907170137.n6H1bXv8029230@godzilla.ics.uci.edu> References: <200907162214.n6GMEo5o025706@godzilla.ics.uci.edu> <871vog89b9.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1247794785 29681 80.91.229.12 (17 Jul 2009 01:39:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Jul 2009 01:39:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?=C3=93scar?= Fuentes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 17 03:39:38 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MRcQD-00083z-AB for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2009 03:39:37 +0200 Original-Received: from localhost ([127.0.0.1]:44668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRcQC-00047L-Pv for ged-emacs-devel@m.gmane.org; Thu, 16 Jul 2009 21:39:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRcPw-0003uS-VS for emacs-devel@gnu.org; Thu, 16 Jul 2009 21:39:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRcPs-0003qC-8c for emacs-devel@gnu.org; Thu, 16 Jul 2009 21:39:20 -0400 Original-Received: from [199.232.76.173] (port=54983 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRcPr-0003q1-Uc for emacs-devel@gnu.org; Thu, 16 Jul 2009 21:39:15 -0400 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:33497) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MRcPr-0004in-GL for emacs-devel@gnu.org; Thu, 16 Jul 2009 21:39:15 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n6H1bYi0007874; Thu, 16 Jul 2009 18:37:34 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n6H1bXv8029230; Thu, 16 Jul 2009 18:37:33 -0700 (PDT) In-Reply-To: <871vog89b9.fsf@telefonica.net> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Fri, 17 Jul 2009 02:03:38 +0200") Original-Lines: 23 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n6H1bYi0007874 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112589 Archived-At: =C3=93scar Fuentes writes: > Dan Nicolaescu writes: >=20 > > diff-mode is set up to show trailing whitespace problems, but it's not > > doing it by default, to enable this one has to do: > > > > (add-hook 'diff-mode-hook 'whitespace-mode) > > > > Vinicius also posted a patch to edit files to clean the trailing > > whitespace problems based on the diff. > > > > Why not turn on whitespace-mode by default in diff-mode? It makes > > spotting whitespace problems very easy, and will make it also easy to > > fix. >=20 > Time ago I posted a patch for removing new trailing whitespace from > files based on their diffs. Vinicius suggested several improvements, so > maybe this code is the one that you mention. Aparently the maintainers > forgot about it and never was incorporated to Emacs.=20 We had a feature freeze for a while, it could be incorporated. Now it can. You can ask Stefan to check it in now.