From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: show whitespace problems by default in diff-mode Date: Thu, 16 Jul 2009 15:53:15 -0700 (PDT) Message-ID: <200907162253.n6GMrF7e026231@godzilla.ics.uci.edu> References: <200907162214.n6GMEo5o025706@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1247784953 9575 80.91.229.12 (16 Jul 2009 22:55:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jul 2009 22:55:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 17 00:55:46 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MRZrc-00065U-LQ for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2009 00:55:44 +0200 Original-Received: from localhost ([127.0.0.1]:42004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRZrc-00039l-08 for ged-emacs-devel@m.gmane.org; Thu, 16 Jul 2009 18:55:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MRZr5-0002jq-LE for emacs-devel@gnu.org; Thu, 16 Jul 2009 18:55:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MRZr1-0002dR-DM for emacs-devel@gnu.org; Thu, 16 Jul 2009 18:55:11 -0400 Original-Received: from [199.232.76.173] (port=45884 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MRZr1-0002dN-5j for emacs-devel@gnu.org; Thu, 16 Jul 2009 18:55:07 -0400 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:56214) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MRZr0-0005Cv-Hm for emacs-devel@gnu.org; Thu, 16 Jul 2009 18:55:06 -0400 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n6GMrFFs017366; Thu, 16 Jul 2009 15:53:15 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n6GMrF7e026231; Thu, 16 Jul 2009 15:53:15 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Thu, 16 Jul 2009 15:33:58 -0700") Original-Lines: 31 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n6GMrFFs017366 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112577 Archived-At: "Drew Adams" writes: > > diff-mode is set up to show trailing whitespace problems, but it's not > > doing it by default, to enable this one has to do: > > > > (add-hook 'diff-mode-hook 'whitespace-mode) > > > > Vinicius also posted a patch to edit files to clean the trailing > > whitespace problems based on the diff. > > > > Why not turn on whitespace-mode by default in diff-mode? It makes > > spotting whitespace problems very easy, and will make it also easy to > > fix. > > Perhaps for the same reason that whitespace diffs are ignored by default by > `diff' - because whitespace differences (including trailing whitespace) are > often _not_ so interesting. Trailing whitespace is an annoyance most of the time, and it's not to be conflated with the rest of the whitespace differences (which diff-mode can ignore just fine -- C-c C-w). > I don't have a particular axe to grind, here. It's just not clear that most > people will want to show whitespace diffs (or even trailing whitespace) most of > the time. If you can support that claim, then sure, go for it. I have yet to see anyone that wants to have trailing whitespace (which are the only thing that might post is concerned with), but it's common to see patches being rejected, or people asked to fix the patches because of trailing whitespace problems. Making it easy to spot and fix such issues just helps our users.