From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: add non-chord keys to repeat isearch Date: Tue, 9 Jun 2009 17:48:07 +0000 Message-ID: <20090609174807.GC11634@muc.de> References: <20090609164716.GA11634@muc.de> <8D5E1C403AD94F20A406381F2679E64A@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1244569635 13241 80.91.229.12 (9 Jun 2009 17:47:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jun 2009 17:47:15 +0000 (UTC) Cc: 'Emacs-Devel devel' To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 09 19:47:12 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ME5Pj-0005ZL-Mj for ged-emacs-devel@m.gmane.org; Tue, 09 Jun 2009 19:47:12 +0200 Original-Received: from localhost ([127.0.0.1]:59301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME5Pi-0007Lv-O6 for ged-emacs-devel@m.gmane.org; Tue, 09 Jun 2009 13:47:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ME5PZ-0007LD-5c for emacs-devel@gnu.org; Tue, 09 Jun 2009 13:47:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ME5PU-0007Jy-Gf for emacs-devel@gnu.org; Tue, 09 Jun 2009 13:47:00 -0400 Original-Received: from [199.232.76.173] (port=57607 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ME5PU-0007Jv-ED for emacs-devel@gnu.org; Tue, 09 Jun 2009 13:46:56 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:3376 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ME5PT-0005KI-Ma for emacs-devel@gnu.org; Tue, 09 Jun 2009 13:46:56 -0400 Original-Received: (qmail 80990 invoked by uid 3782); 9 Jun 2009 17:46:53 -0000 Original-Received: from acm.muc.de (pD9E234E7.dip.t-dialin.net [217.226.52.231]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Tue, 09 Jun 2009 19:46:51 +0200 Original-Received: (qmail 14446 invoked by uid 1000); 9 Jun 2009 17:48:08 -0000 Content-Disposition: inline In-Reply-To: <8D5E1C403AD94F20A406381F2679E64A@us.oracle.com> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111398 Archived-At: Hi, Drew! On Tue, Jun 09, 2009 at 10:08:34AM -0700, Drew Adams wrote: > > Please don't. These two keys are already used in Isearch Mode for > > scrolling. To see this, set `isearch-allow-scroll' to t. Then > > and are handy keys for seeing more text around the > > match without having to leave isearch and start again. > (I wasn't aware of that option. I've just filed a bug to index it in > the Emacs manual.) > However, just because some binding was made previously (when someone > first had the idea of scrolling without exiting Isearch) is no reason > not to reconsider that binding in light of a better suggestion. Emacs > is not purely first-come-first-served. That someone was me, by the way. > `M-v' and `C-v' can be used for scrolling (when the option is non-nil). > And `' and `' can be used for repeat search. There's room > for all. What about people's poor pinkies while operating those key sequences? ;-) Of course, another idea would be to allow C-s (etc.) to get a repeat count - wouldn't be at all hard to do. C-u C-u C-s could take you a long, long way. > [BTW, scrolling during isearch doesn't seem to work beyond a single > screen height. Is that a bug or a feature? IOW, `C-s C-v C-v': the > second `C-v' has no effect.] It's a feature as far as I'm concerned, a bug to a few others. In Emacs, point is always in the Window, so this carries over quite naturally to the whole isearch match staying in the window, too. The other design alternative would have been to allow point to scroll to the top/bottom of the window even when that would put part of the match outside it. As a matter of interest, you can give a repeat count to scroll that number of lines. > > The same applies to any keys bound to commands which have the > > `isearch-scroll' non-nil. > That's fine, but a specific key binding can override that. We can > choose to bind `' to `isearch-repeat-backward' even though > `scroll-up' has non-nil property `isearch-scroll'. Works fine. There is > no need to sacrifice all keys that might be bound globally to > `scroll-up'. For consistency, the same operation (modulo your above comment) should have the same key binding(s) inside and outside Isearch Mode. If any (non self-inserting) keys have a standard meaning throughout "all" computer programs, it's surely and . Another argument in their favour is that anybody who's scrolling up and down within Isearch is in a mode where there's no cost in using keys not in the home position. I quite often scroll up and down in rapid succession (in isearch), and would find switching between C-v and M-v intolerably awkward. -- Alan Mackenzie (Nuremberg, Germany).