From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: bug#3269: 23.0.93; C-mode text highlighting Date: Tue, 19 May 2009 22:40:21 +0000 Message-ID: <20090519224021.GA7126@muc.de> References: <878wl1h5fw.fsf@ancient.thomaschristensen.org> <20090514213924.GB2413@muc.de> <20090518150643.GA12920@muc.de> <20090518213030.GD12920@muc.de> <20090519102619.GA1317@muc.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1242772803 5873 80.91.229.12 (19 May 2009 22:40:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 May 2009 22:40:03 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Chong Yidong , 3269@emacsbugs.donarmstrong.com, Thomas Christensen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 20 00:39:55 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M6XyU-0008St-RL for ged-emacs-devel@m.gmane.org; Wed, 20 May 2009 00:39:55 +0200 Original-Received: from localhost ([127.0.0.1]:51320 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6XyT-0005hH-Vh for ged-emacs-devel@m.gmane.org; Tue, 19 May 2009 18:39:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M6XyO-0005gM-Fr for emacs-devel@gnu.org; Tue, 19 May 2009 18:39:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M6XyJ-0005cH-UW for emacs-devel@gnu.org; Tue, 19 May 2009 18:39:48 -0400 Original-Received: from [199.232.76.173] (port=39411 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M6XyJ-0005cE-RC for emacs-devel@gnu.org; Tue, 19 May 2009 18:39:43 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:3116 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M6XyJ-000374-CJ for emacs-devel@gnu.org; Tue, 19 May 2009 18:39:43 -0400 Original-Received: (qmail 79442 invoked by uid 3782); 19 May 2009 22:39:40 -0000 Original-Received: from acm.muc.de (pD9E51DA3.dip.t-dialin.net [217.229.29.163]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Wed, 20 May 2009 00:39:37 +0200 Original-Received: (qmail 7163 invoked by uid 1000); 19 May 2009 22:40:21 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) X-Primary-Address: acm@muc.de X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110988 gmane.emacs.pretest.bugs:24473 Archived-At: Hi, All! On Tue, May 19, 2009 at 10:36:05AM -0400, Stefan Monnier wrote: > >> In other words, messed-up highlighting for incorrect code is just as > >> good if not better than explicitly recognizing the incorrect code and > >> highlighting it with f-l-warning-face. > > I was thinking of "compatibility" with unterminated strings in normal > > code. But they're not the same thing. An open string in a #define is > > perfectly valid code, if somewhat unusual outside of the Obfuscated C > > competition. > > You've persuaded me that the existing fontification is actually better. > > So I won't be committing yesterday's patch. Thanks! > I'm glad we ended up agreeing, tho for completely different reasons. > > I'll just finish the other patch and commit that. DONE. > Stefan -- Alan Mackenzie (Nuremberg, Germany).