From: Harald Hanche-Olsen <hanche@math.ntnu.no>
To: monnier@iro.umontreal.ca
Cc: schwab@linux-m68k.org, borja.tarraso.hueso@googlemail.com,
emacs-devel@gnu.org
Subject: Re: Possible emacs bug when type password fields
Date: Wed, 06 May 2009 17:08:01 +0200 (CEST) [thread overview]
Message-ID: <20090506.170801.234569630.hanche@math.ntnu.no> (raw)
In-Reply-To: <jwv1vr2l35q.fsf-monnier+emacs@gnu.org>
+ Stefan Monnier <monnier@iro.umontreal.ca>:
> >> --- lisp/subr.el 2009-05-02 00:32:01 +0000
> >> +++ lisp/subr.el 2009-05-06 01:21:02 +0000
> >> @@ -1997,10 +1997,11 @@
> >> (and (arrayp pass) (clear-string pass))
> >> (setq pass new-pass))))
> >> ((not (numberp c)))
> >> - ((= c ?\C-u) ; kill line
> >> + ((eq c ?\C-u) ; kill line
>
> > That should not make a difference, since c is guaranteed to be a number
> > here.
>
> That's the thing: by changing red-char into read-key (done by the
> previous patch), it is not guaranteed any more.
I don't get it. How is c not guaranteed to be a number in a cond
clause following the clause
((not (numberp c)))
?
- Harald
next prev parent reply other threads:[~2009-05-06 15:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 11:13 Possible emacs bug when type password fields Borja Tarraso Hueso
2009-05-01 16:42 ` Harald Hanche-Olsen
2009-05-01 19:57 ` Stefan Monnier
2009-05-01 21:28 ` Harald Hanche-Olsen
2009-05-05 18:36 ` Borja Tarraso
2009-05-06 1:21 ` Stefan Monnier
2009-05-06 8:57 ` Andreas Schwab
2009-05-06 14:25 ` Stefan Monnier
2009-05-06 15:08 ` Harald Hanche-Olsen [this message]
2009-05-06 15:08 ` Andreas Schwab
2009-05-06 18:58 ` Stefan Monnier
2009-05-07 20:53 ` Borja Tarraso
2009-05-08 1:01 ` Stefan Monnier
2009-05-14 0:35 ` Borja Tarraso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090506.170801.234569630.hanche@math.ntnu.no \
--to=hanche@math.ntnu.no \
--cc=borja.tarraso.hueso@googlemail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).