From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: Re: load_charset warning Date: Fri, 1 May 2009 13:06:29 +0200 Message-ID: <20090501110629.GC37259@orion.local> References: <20090501104053.GB37259@orion.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="WhfpMioaduB5tiZL" X-Trace: ger.gmane.org 1241176021 19829 80.91.229.12 (1 May 2009 11:07:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 May 2009 11:07:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 01 13:06:52 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LzqZv-00077d-BN for ged-emacs-devel@m.gmane.org; Fri, 01 May 2009 13:06:51 +0200 Original-Received: from localhost ([127.0.0.1]:41644 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzqZu-0002F8-Cd for ged-emacs-devel@m.gmane.org; Fri, 01 May 2009 07:06:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzqZe-0002EE-ED for emacs-devel@gnu.org; Fri, 01 May 2009 07:06:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzqZc-0002De-23 for emacs-devel@gnu.org; Fri, 01 May 2009 07:06:32 -0400 Original-Received: from [199.232.76.173] (port=56701 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzqZb-0002DS-0z for emacs-devel@gnu.org; Fri, 01 May 2009 07:06:31 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.158]:55596) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzqZa-0002JJ-G5 for emacs-devel@gnu.org; Fri, 01 May 2009 07:06:30 -0400 Original-Received: by fg-out-1718.google.com with SMTP id e12so695234fga.7 for ; Fri, 01 May 2009 04:06:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to; bh=CIZuzKxfDF7mE2vlj9ZB/ZT8isfjOjU3vrkt116K22Q=; b=RZOLFXO9ZaEDfDDxdC/f3SbGZ20+Fi0QscidVPUIyWffuNGes8iWvJsibNV3nr8kzP aHcJFghJwUUliTss3Yc/VZvF5Ke9x6jr8Dw4vFd1bTcUTI6zIUb3j8zaTl6UFFoq1wAC zB0TBjyjgttWiKoduUmTI34/Csgeg/IMUFwZE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to; b=cx/risrEsGSyjhI4vph5HIg0cWqbGRyewwB8Kf3KQAUSQv7vuLDBW+YVAFNsqdsKf5 Q1Xufch5OGbYlkcgv3J+0y/w8YJYAEA5VCRkjxaOpSyb1Wrb/E2jJsfGLorkGVc5hA2a A5rI7A8KW3QJyUGbeqqpvDKb1eeGQvPL3Y1WQ= Original-Received: by 10.86.61.13 with SMTP id j13mr2746127fga.48.1241175989707; Fri, 01 May 2009 04:06:29 -0700 (PDT) Original-Received: from localhost (host33-106-dynamic.16-87-r.retail.telecomitalia.it [87.16.106.33]) by mx.google.com with ESMTPS id 3sm605881fge.24.2009.05.01.04.06.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 May 2009 04:06:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110584 Archived-At: --WhfpMioaduB5tiZL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 01, 2009 at 07:56:23PM +0900, Kenichi Handa wrote: > In article <20090501104053.GB37259@orion.local>, Emanuele Giaquinta writes: > > > gcc emits the following warning for charset.c:load_charset: > > > charset.c: In function 'load_charset': > > charset.c:649: warning: comparisons like X<=Y<=Z do not have their mathematical meaning > > > Since the code seems correct, i'd suggest the attached patch to > > improve readability (and avoid the warning). > > Thank you. I committed your change. I also noticed a useless assignment to for_encoder, see attached patch. Emanuele Giaquinta --WhfpMioaduB5tiZL Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="load_charset_map.diff" diff --git a/src/charset.c b/src/charset.c index 15975a4..7d9bc2f 100644 --- a/src/charset.c +++ b/src/charset.c @@ -319,7 +319,6 @@ load_charset_map (charset, entries, n_entries, control_flag) { memset (temp_charset_work->table.decoder, -1, sizeof (int) * 0x10000); - temp_charset_work->for_encoder = 0; } else { --WhfpMioaduB5tiZL--