From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: load_charset warning Date: Fri, 1 May 2009 12:40:53 +0200 Message-ID: <20090501104053.GB37259@orion.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="gBBFr7Ir9EOA20Yy" X-Trace: ger.gmane.org 1241174477 16096 80.91.229.12 (1 May 2009 10:41:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 May 2009 10:41:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 01 12:41:07 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LzqAz-0005b3-Vj for ged-emacs-devel@m.gmane.org; Fri, 01 May 2009 12:41:06 +0200 Original-Received: from localhost ([127.0.0.1]:38066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzqAz-0001B7-EK for ged-emacs-devel@m.gmane.org; Fri, 01 May 2009 06:41:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LzqAt-0001B2-Mr for emacs-devel@gnu.org; Fri, 01 May 2009 06:40:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LzqAr-0001A7-Mq for emacs-devel@gnu.org; Fri, 01 May 2009 06:40:58 -0400 Original-Received: from [199.232.76.173] (port=51581 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LzqAr-0001A1-Ie for emacs-devel@gnu.org; Fri, 01 May 2009 06:40:57 -0400 Original-Received: from fg-out-1718.google.com ([72.14.220.158]:56718) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LzqAr-0004y3-6i for emacs-devel@gnu.org; Fri, 01 May 2009 06:40:57 -0400 Original-Received: by fg-out-1718.google.com with SMTP id l27so40722fgb.7 for ; Fri, 01 May 2009 03:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition; bh=Zhi43+48ayqxoJaDd7McXY/r9P3OZXDmpG+ln8v0MCM=; b=fGS8ag8nItPnwqXca6kMhlRUs5DrwTspAeJ7A/9musNa5ro6Lu4WSqDlyCm08QzHDh AGDUQwA2JrpBxbFlmWAKHyUzcANCfEGqVYMuquLwczkXqH7rAtSRqUYTmt/xbT1FBmio M3OQCpZJnyP9BtyHeHp74r5I9itz7ib9TBu78= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition; b=ptwg/WlSV/fnAMmIradSN1EgmciAjqVn1aEh+I6fix1TMwjIzn2ECbASTcfZu98Bcv SDSU7shI/bcd4dPIN+Sl5Lsr5WlJv3dONljQGu1sbg/Oze/XEnQ0tRAnm+ug0jEUxTSQ Y9wP8bFtGijmmP8tkV74z859hSQnRY7gu1D/w= Original-Received: by 10.86.93.17 with SMTP id q17mr2729423fgb.75.1241174453027; Fri, 01 May 2009 03:40:53 -0700 (PDT) Original-Received: from localhost (host33-106-dynamic.16-87-r.retail.telecomitalia.it [87.16.106.33]) by mx.google.com with ESMTPS id d4sm5182340fga.9.2009.05.01.03.40.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 01 May 2009 03:40:52 -0700 (PDT) Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110582 Archived-At: --gBBFr7Ir9EOA20Yy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, gcc emits the following warning for charset.c:load_charset: charset.c: In function 'load_charset': charset.c:649: warning: comparisons like X<=Y<=Z do not have their mathematical meaning Since the code seems correct, i'd suggest the attached patch to improve readability (and avoid the warning). Emanuele Giaquinta --gBBFr7Ir9EOA20Yy Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="load_charset.diff" diff --git a/src/charset.c b/src/charset.c index 15975a4..107647f 100644 --- a/src/charset.c +++ b/src/charset.c @@ -646,7 +646,7 @@ load_charset (charset, control_flag) if (inhibit_load_charset_map && temp_charset_work && charset == temp_charset_work->current - && (control_flag == 2 == temp_charset_work->for_encoder)) + && ((control_flag == 2) == temp_charset_work->for_encoder)) return; if (CHARSET_METHOD (charset) == CHARSET_METHOD_MAP) --gBBFr7Ir9EOA20Yy--