From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: signed vs unsigned char in coding.h Date: Fri, 20 Feb 2009 08:19:11 -0800 (PST) Message-ID: <200902201619.n1KGJBtJ006483@rodan.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1235146799 16492 80.91.229.12 (20 Feb 2009 16:19:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2009 16:19:59 +0000 (UTC) Cc: Kenichi Handa To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 20 17:21:11 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LaY7h-0000O7-ML for ged-emacs-devel@m.gmane.org; Fri, 20 Feb 2009 17:21:09 +0100 Original-Received: from localhost ([127.0.0.1]:47886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LaY6N-0005aQ-AA for ged-emacs-devel@m.gmane.org; Fri, 20 Feb 2009 11:19:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LaY62-0005PZ-Dj for emacs-devel@gnu.org; Fri, 20 Feb 2009 11:19:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LaY5z-0005OU-Mp for emacs-devel@gnu.org; Fri, 20 Feb 2009 11:19:24 -0500 Original-Received: from [199.232.76.173] (port=55525 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LaY5z-0005OO-HL for emacs-devel@gnu.org; Fri, 20 Feb 2009 11:19:23 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:59687) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LaY5y-0008Kn-SO for emacs-devel@gnu.org; Fri, 20 Feb 2009 11:19:23 -0500 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n1KGJBPo026407; Fri, 20 Feb 2009 08:19:12 -0800 (PST) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n1KGJBtJ006483; Fri, 20 Feb 2009 08:19:11 -0800 (PST) Original-Lines: 16 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n1KGJBPo026407 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109254 Archived-At: struct coding_system in coding.h contains this: char *safe_charsets; and coding.c has this: #define SAFE_CHARSET_P(coding, id) \ ((id) <= (coding)->max_charset_id \ && (coding)->safe_charsets[id] >= 0) on some platforms "char" is unsigned by default, so the above >=0 comparison is always true. What is the intention here, should safe_charsets be defined as "signed char" ?