From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: VC Development Date: Mon, 2 Feb 2009 10:44:03 -0800 (PST) Message-ID: <200902021844.n12Ii332020674@rodan.ics.uci.edu> References: <18820.57748.262639.494922@kahikatea.snap.net.nz> <8763ju6gh9.fsf@cyd.mit.edu> <200902010602.n11620Ek019863@rodan.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233600292 13407 80.91.229.12 (2 Feb 2009 18:44:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Feb 2009 18:44:52 +0000 (UTC) Cc: Chong Yidong , Nick Roberts , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 02 19:46:06 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LU3ny-0005Fn-1D for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2009 19:45:58 +0100 Original-Received: from localhost ([127.0.0.1]:46912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU3mf-0008Ee-F8 for ged-emacs-devel@m.gmane.org; Mon, 02 Feb 2009 13:44:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LU3mZ-0008B4-Lq for emacs-devel@gnu.org; Mon, 02 Feb 2009 13:44:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LU3mV-0008AW-K6 for emacs-devel@gnu.org; Mon, 02 Feb 2009 13:44:30 -0500 Original-Received: from [199.232.76.173] (port=58718 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LU3mV-0008AS-C4 for emacs-devel@gnu.org; Mon, 02 Feb 2009 13:44:27 -0500 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:55832) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LU3mU-0006va-NB for emacs-devel@gnu.org; Mon, 02 Feb 2009 13:44:27 -0500 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n12Ii4SP010629; Mon, 2 Feb 2009 10:44:04 -0800 (PST) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n12Ii332020674; Mon, 2 Feb 2009 10:44:03 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sun, 01 Feb 2009 16:22:03 -0500") Original-Lines: 19 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n12Ii4SP010629 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108616 Archived-At: Stefan Monnier writes: > > Seeing obviously wrong stuff like this: > > +;; Keep existing map. > > +(defvar vc-dir-mouse-map > > + (let ((map vc-dir-mode-map)) > > + (define-key map [mouse-2] 'vc-dir-find-file-other-window) > > + map) > > + "Local keymap for visiting a file.") > > I don't have time to fix it properly now, so the best thing to do is to > > revert it. > > No, the best thing to do is to report it here (or on emacsbugs). In general, maybe. But absolutely NOT in this particular case: obviously broken and clearly untested stuff 2 days before the prestest and I have no time to properly fix it. And the person making the change has shown time and again that is not interested in anything else but personal attacks. Sorry, I don't have any intention on wasting time on that.