From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: VC Development Date: Sat, 31 Jan 2009 22:02:00 -0800 (PST) Message-ID: <200902010602.n11620Ek019863@rodan.ics.uci.edu> References: <18820.57748.262639.494922@kahikatea.snap.net.nz> <8763ju6gh9.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1233468285 10196 80.91.229.12 (1 Feb 2009 06:04:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Feb 2009 06:04:45 +0000 (UTC) Cc: Nick Roberts , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 01 07:05:56 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LTVSH-0007uo-8I for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2009 07:05:41 +0100 Original-Received: from localhost ([127.0.0.1]:60385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTVQy-0001H9-Rq for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2009 01:03:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LTVPH-0000od-Px for emacs-devel@gnu.org; Sun, 01 Feb 2009 01:02:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LTVPG-0000nn-41 for emacs-devel@gnu.org; Sun, 01 Feb 2009 01:02:10 -0500 Original-Received: from [199.232.76.173] (port=60059 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LTVPF-0000nb-Mu for emacs-devel@gnu.org; Sun, 01 Feb 2009 01:02:09 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:33975) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LTVPF-0007RQ-14 for emacs-devel@gnu.org; Sun, 01 Feb 2009 01:02:09 -0500 Original-Received: from rodan.ics.uci.edu (rodan.ics.uci.edu [128.195.6.9]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n11621wa019955; Sat, 31 Jan 2009 22:02:01 -0800 (PST) Original-Received: (from dann@localhost) by rodan.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n11620Ek019863; Sat, 31 Jan 2009 22:02:00 -0800 (PST) In-Reply-To: <8763ju6gh9.fsf@cyd.mit.edu> (Chong Yidong's message of "Sat, 31 Jan 2009 21:25:22 -0500") Original-Lines: 39 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n11621wa019955 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@rodan.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108495 Archived-At: Chong Yidong writes: > Nick Roberts writes: > > >> It's even more strange that version control is so important nowadays, > >> and just about everyone seems to have a very strong opinion about it, > >> but not enough to want to contribute to VC... > > > > One reason that makes it unattractive to me is the fact that you > > revert changes without discussion: > > > > 2009-01-31 Dan Nicolaescu > > > > * vc-dir.el (vc-dir-mouse-map): > > (vc-default-dir-printer): > > (vc-dir-find-file-other-window): Undo previous change, it breaks > > the behavior of mouse-2. > > Indeed: please, at minimum, send a message to emacs-devel before Sorry, I gave up on trying to talk to that person a while ago when he became the founding member of my killfile due to getting tired of his incessant personal attacks. I welcome patches, but it's highly inappropriate to check in an obviously untested change 2 days before the pretest into a well maintained package without any kind of heads up. Seeing obviously wrong stuff like this: +;; Keep existing map. +(defvar vc-dir-mouse-map + (let ((map vc-dir-mode-map)) + (define-key map [mouse-2] 'vc-dir-find-file-other-window) + map) + "Local keymap for visiting a file.") I don't have time to fix it properly now, so the best thing to do is to revert it. I don't have time to waist on an email discussion for such a trivial issue.