From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Patch: goto-address minor modes Date: Tue, 13 Jan 2009 22:11:36 -0800 (PST) Message-ID: <200901140611.n0E6Baf3013474@mothra.ics.uci.edu> References: <87zlhuag0r.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231913569 31625 80.91.229.12 (14 Jan 2009 06:12:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Jan 2009 06:12:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 14 07:14:01 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LMz0p-0006Fl-JF for ged-emacs-devel@m.gmane.org; Wed, 14 Jan 2009 07:13:59 +0100 Original-Received: from localhost ([127.0.0.1]:56884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMyzY-0003KN-W7 for ged-emacs-devel@m.gmane.org; Wed, 14 Jan 2009 01:12:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMyyg-0002jy-ME for emacs-devel@gnu.org; Wed, 14 Jan 2009 01:11:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMyye-0002i7-1N for emacs-devel@gnu.org; Wed, 14 Jan 2009 01:11:45 -0500 Original-Received: from [199.232.76.173] (port=40684 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMyyd-0002hq-Hm for emacs-devel@gnu.org; Wed, 14 Jan 2009 01:11:43 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:35705) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LMyyd-000195-2j for emacs-devel@gnu.org; Wed, 14 Jan 2009 01:11:43 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id n0E6BaPl005788; Tue, 13 Jan 2009 22:11:36 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n0E6Baf3013474; Tue, 13 Jan 2009 22:11:36 -0800 (PST) In-Reply-To: <87zlhuag0r.fsf@jurta.org> (Juri Linkov's message of "Wed, 14 Jan 2009 02:27:16 +0200") Original-Lines: 24 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n0E6BaPl005788 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107840 Archived-At: Juri Linkov writes: > goto-address-mode is now a minor mode like bug-reference-mode. > bug-reference-mode uses the `link' face to highlight links, > but goto-address-mode still uses `bold'. The following patch > changes address urls to be highlighted in the `link' face. > Also it takes a new minor mode into use in several places: > > Index: lisp/net/goto-addr.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/net/goto-addr.el,v > retrieving revision 1.35 > diff -u -r1.35 goto-addr.el > --- lisp/net/goto-addr.el 5 Jan 2009 03:22:44 -0000 1.35 > +++ lisp/net/goto-addr.el 14 Jan 2009 00:21:07 -0000 > @@ -129,7 +129,7 @@ > m) > "Keymap to hold goto-addr's mouse key defs under highlighted URLs.") > > -(defcustom goto-address-url-face 'bold > +(defcustom goto-address-url-face 'link This is nice! Shouldn't the links in the *Help* buffers also use the `link' face?