From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: implement Solaris support for system-process-attributes and list-system-processes Date: Fri, 19 Dec 2008 11:51:51 -0800 (PST) Message-ID: <200812191951.mBJJppdX016721@mothra.ics.uci.edu> References: <200812180916.mBI9GJtr012310@mothra.ics.uci.edu> <200812190745.mBJ7jWVe015085@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229716395 27925 80.91.229.12 (19 Dec 2008 19:53:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Dec 2008 19:53:15 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 19 20:54:19 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LDlQQ-0007Ue-GU for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2008 20:54:18 +0100 Original-Received: from localhost ([127.0.0.1]:36903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDlPE-0002JK-0E for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2008 14:53:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDlOJ-0001iE-HN for emacs-devel@gnu.org; Fri, 19 Dec 2008 14:52:07 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDlOE-0001f0-Of for emacs-devel@gnu.org; Fri, 19 Dec 2008 14:52:03 -0500 Original-Received: from [199.232.76.173] (port=59805 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDlOD-0001eh-Q7 for emacs-devel@gnu.org; Fri, 19 Dec 2008 14:52:01 -0500 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:54403) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LDlOA-0000Zf-LE; Fri, 19 Dec 2008 14:51:59 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id mBJJppD5007693; Fri, 19 Dec 2008 11:51:51 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mBJJppdX016721; Fri, 19 Dec 2008 11:51:51 -0800 (PST) In-Reply-To: (Miles Bader's message of "Fri, 19 Dec 2008 17:48:59 +0900") Original-Lines: 19 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mBJJppD5007693 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_OC 0.08) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107075 Archived-At: Miles Bader writes: > Dan Nicolaescu writes: > > How does this sound: > > - move the procfs_list_system_processes and procfs_system_process_attributes to sysdep.c > > - remove the procfs_ prefix > > - add the proper #defines (HAVE_PROCFS can probably be used by a few OSes) > > - the default implementations just return Qnil > > - make Fsystem_process_attributes and Flist_system_processes just call > > list_system_processes and system_process_attributes > > - rename the w32 versions to system_process_attributes and list_system_processes > > - remove the PROCATTR and LISTPROC macros > > ? > > ... and while you're at it, rename Fsystem_process_attributes to > "Fprocess_attributes" and make it also accept emacs process objects as > an argument, ala signal-process. Sounds good to me, but I'd rather let someone else do those changes.