From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: files.el: Patch to make project-settings optional/customizable Date: Sun, 23 Nov 2008 19:06:49 -0800 (PST) Message-ID: <200811240306.mAO36nfl025031@mothra.ics.uci.edu> References: <5f0ff9220811130629t505badf9kb1bcc380df89a08f@mail.gmail.com> <87prkz4kgh.fsf@cyd.mit.edu> <200811131728.mADHSH2M010654@mothra.ics.uci.edu> <871vxflbxb.fsf@cyd.mit.edu> <200811131848.mADImPMQ011099@mothra.ics.uci.edu> <200811181636.mAIGa9Lx000571@mothra.ics.uci.edu> <87prks6693.fsf@jurta.org> <87iqqjcp3j.fsf@jurta.org> <87zljrh93w.fsf@jurta.org> <200811221940.mAMJeMpj020419@mothra.ics.uci.edu> <87ej13h73g.fsf@jurta.org> <200811222020.mAMKKBcY020496@mothra.ics.uci.edu> <87zljrm7yh.fsf@catnip.gol.com> <200811230810.mAN8A6fp022636@mothra.ics.uci.edu> <87ljvayb18.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227504603 6583 80.91.229.12 (24 Nov 2008 05:30:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Nov 2008 05:30:03 +0000 (UTC) Cc: Tom Tromey , "T.V. Raman" , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 24 06:31:05 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L4U2K-0001ib-LR for ged-emacs-devel@m.gmane.org; Mon, 24 Nov 2008 06:31:04 +0100 Original-Received: from localhost ([127.0.0.1]:49741 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4U1B-0000n3-C6 for ged-emacs-devel@m.gmane.org; Mon, 24 Nov 2008 00:29:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4U11-0000lu-Qa for emacs-devel@gnu.org; Mon, 24 Nov 2008 00:29:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4U10-0000kq-0m for emacs-devel@gnu.org; Mon, 24 Nov 2008 00:29:42 -0500 Original-Received: from [199.232.76.173] (port=44289 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4U0z-0000kk-Nc for emacs-devel@gnu.org; Mon, 24 Nov 2008 00:29:41 -0500 Original-Received: from barrelv2.ics.uci.edu ([128.195.1.114]:48773) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1L4Rmu-000261-O3 for emacs-devel@gnu.org; Sun, 23 Nov 2008 22:07:01 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mAO36p7u027958; Sun, 23 Nov 2008 19:06:51 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mAO36nfl025031; Sun, 23 Nov 2008 19:06:49 -0800 (PST) In-Reply-To: <87ljvayb18.fsf@jurta.org> (Juri Linkov's message of "Sun, 23 Nov 2008 12:45:59 +0200") Original-Lines: 31 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mAO36p7u027958 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106061 Archived-At: Juri Linkov writes: > > So there are 2 uses .dir-locals.el 3 lines apart in the same 24 lines function. > > The defconst adds 4 lines. It's hard to keep a straight face and claim > > that the defconst is a good idea. > > (and the 2 uses could be reduced to a single one if we make > > locate-dominating-file return an expanded file name -- which seems to be > > a good idea anyway). > > > > It's kind of painful that this discussion is still going on, it should > > have never occurred in the first place... > > I can't believe we have this kind of discussion :( Yeah, it could have been avoided by not adding the defconst, which is quite obvious by now that was only added to circumvent the fact that the settings file name should not be changeable by the user. And that is not just a whim, it's an issue of robustness and quality of implementation. More, adding the defconst does not fix any bug, so it shouldn't have been done at this point. Even more, it does cost something: the pure size increases by 28 bytes, and the data size of emacs by 8K (might have hit a page boundary condition). As shown by the actual code, it is more lines of code, so it is not simplifying anything. But it does make it easy to break the feature. So please revert that change.