From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: files.el: Patch to make project-settings optional/customizable Date: Sat, 22 Nov 2008 11:40:22 -0800 (PST) Message-ID: <200811221940.mAMJeMpj020419@mothra.ics.uci.edu> References: <5f0ff9220811130629t505badf9kb1bcc380df89a08f@mail.gmail.com> <200811131619.mADGJukm010206@mothra.ics.uci.edu> <87prkz4kgh.fsf@cyd.mit.edu> <200811131728.mADHSH2M010654@mothra.ics.uci.edu> <871vxflbxb.fsf@cyd.mit.edu> <200811131848.mADImPMQ011099@mothra.ics.uci.edu> <200811181636.mAIGa9Lx000571@mothra.ics.uci.edu> <87prks6693.fsf@jurta.org> <87iqqjcp3j.fsf@jurta.org> <87zljrh93w.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1227382850 11257 80.91.229.12 (22 Nov 2008 19:40:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Nov 2008 19:40:50 +0000 (UTC) Cc: Tom Tromey , "T.V. Raman" , Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 22 20:41:53 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L3yMa-0003cf-GH for ged-emacs-devel@m.gmane.org; Sat, 22 Nov 2008 20:41:52 +0100 Original-Received: from localhost ([127.0.0.1]:35767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3yLR-0001Bt-EC for ged-emacs-devel@m.gmane.org; Sat, 22 Nov 2008 14:40:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3yLN-0001Bm-5h for emacs-devel@gnu.org; Sat, 22 Nov 2008 14:40:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3yLJ-0001Ba-Kv for emacs-devel@gnu.org; Sat, 22 Nov 2008 14:40:35 -0500 Original-Received: from [199.232.76.173] (port=57583 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3yLJ-0001BX-GX for emacs-devel@gnu.org; Sat, 22 Nov 2008 14:40:33 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:49682) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1L3yLJ-0003S2-DU for emacs-devel@gnu.org; Sat, 22 Nov 2008 14:40:33 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mAMJeOkJ014423; Sat, 22 Nov 2008 11:40:25 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mAMJeMpj020419; Sat, 22 Nov 2008 11:40:22 -0800 (PST) In-Reply-To: <87zljrh93w.fsf@jurta.org> (Juri Linkov's message of "Sat, 22 Nov 2008 21:08:19 +0200") Original-Lines: 28 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mAMJeOkJ014423 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105972 Archived-At: Juri Linkov writes: > >> So let's get rid of "project" in the function names and use the common > >> prefix dir-local-variables by analogy with file-local-variables. > > > > Sounds OK. > > > >> Since the only term the user have to remember will be "directory-local > >> variables" this suggests using a file name derived from it. Since > >> the file name should be short a good candidate is ".dir-locals.el". > > > > Fine by me, > > Done. Thanks for doing this! > Since seeing constant file names repeated in several places hurts my eyes, > I also created defconst for the file name, as Richard suggested - with the > docstring saying why it is constant. Since dir-locals-file is used in exactly one function, it would be better to just let bind it there. And defconsts are not exactly constants in elisp, so if someone does a (setq dir-locals-file BLAH), the problem that started this whole discussion still happens. More, we don't have defconsts for "Local Variables" or "-*-" which serve a similar purpose but at file level.