From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: files.el: Patch to make project-settings optional/customizable Date: Thu, 13 Nov 2008 10:48:25 -0800 (PST) Message-ID: <200811131848.mADImPMQ011099@mothra.ics.uci.edu> References: <5f0ff9220811130629t505badf9kb1bcc380df89a08f@mail.gmail.com> <87y6zn4pqw.fsf@cyd.mit.edu> <200811131607.mADG71u6010167@mothra.ics.uci.edu> <200811131619.mADGJukm010206@mothra.ics.uci.edu> <87prkz4kgh.fsf@cyd.mit.edu> <200811131728.mADHSH2M010654@mothra.ics.uci.edu> <871vxflbxb.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226602134 4107 80.91.229.12 (13 Nov 2008 18:48:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Nov 2008 18:48:54 +0000 (UTC) Cc: Tom Tromey , "T.V. Raman" , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 13 19:49:55 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0hGH-0003lC-BM for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 19:49:49 +0100 Original-Received: from localhost ([127.0.0.1]:59699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0hF9-00028y-Am for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 13:48:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0hF5-00028R-Hc for emacs-devel@gnu.org; Thu, 13 Nov 2008 13:48:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0hF4-00028F-SF for emacs-devel@gnu.org; Thu, 13 Nov 2008 13:48:35 -0500 Original-Received: from [199.232.76.173] (port=48637 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0hF4-00028C-QF for emacs-devel@gnu.org; Thu, 13 Nov 2008 13:48:34 -0500 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:42082) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1L0hF4-0007Kv-9s for emacs-devel@gnu.org; Thu, 13 Nov 2008 13:48:34 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id mADImQZf009419; Thu, 13 Nov 2008 10:48:26 -0800 (PST) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id mADImPMQ011099; Thu, 13 Nov 2008 10:48:25 -0800 (PST) In-Reply-To: <871vxflbxb.fsf@cyd.mit.edu> (Chong Yidong's message of "Thu, 13 Nov 2008 13:26:40 -0500") Original-Lines: 31 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: mADImQZf009419 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105662 Archived-At: Chong Yidong writes: > Dan Nicolaescu writes: > > > > I think it's generally good policy to avoid hardcoding file names. > > > > But general policy should not be applied without thinking about the > > particulars of each case. As Tom said, there were some long > > discussions about this, and I think that the opposite conclusion was > > reached _for this particular case_. Just undoing that decision > > without reviewing the previous discussions on this does not seem like > > a good idea. > > I can't seem to find the discussion. Could you point me to it? I don't have anything handy, I'd guess that searching for .dir-settings.el and Tom's name should be good enough. > (Even if we decide to hardcode the name, which I'm not convinced about, > there needs to be a comment in the code explaining why.) Say one works on emacs -- that has (not now, but we should add it) .dir-settings.el that sets c-set-style to "gnu" linux -- that might have .dir-settings.el that sets c-set-style to "linux" .emacs that sets project-settings-file to "my-cool-name-for-project-settings.el" my-own-project -- that has my-cool-name-for-project-settings.el that sets c-set-style to "k&r" after that when working in my-own-project the C style is set correctly, and it is silently ignored for emacs and linux. Sort of defeats the purpose of having this.