From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tim Penhey Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] vc-bzr.el: avoid stomping files across hardlink branches. Date: Mon, 10 Nov 2008 15:29:35 +1300 Message-ID: <200811101529.36589.tim@penhey.net> References: <200810292207.58558.tim@penhey.net> <874p2h36n4.fsf@red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1226287662 3911 80.91.229.12 (10 Nov 2008 03:27:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Nov 2008 03:27:42 +0000 (UTC) Cc: Karl Fogel , Barry Warsaw , Emacs Development To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 10 04:28:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KzNSF-00032q-37 for ged-emacs-devel@m.gmane.org; Mon, 10 Nov 2008 04:28:43 +0100 Original-Received: from localhost ([127.0.0.1]:50877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzNR6-0004Gu-VU for ged-emacs-devel@m.gmane.org; Sun, 09 Nov 2008 22:27:32 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KzMvQ-0003tC-VS for emacs-devel@gnu.org; Sun, 09 Nov 2008 21:54:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KzMvO-0003rg-8r for emacs-devel@gnu.org; Sun, 09 Nov 2008 21:54:48 -0500 Original-Received: from [199.232.76.173] (port=35702 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KzMvO-0003rY-1Q for emacs-devel@gnu.org; Sun, 09 Nov 2008 21:54:46 -0500 Original-Received: from 125-236-193-95.adsl.xtra.co.nz ([125.236.193.95]:38081 helo=mini) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KzMvN-0002c7-C1 for emacs-devel@gnu.org; Sun, 09 Nov 2008 21:54:45 -0500 Original-Received: from slacko.localnet (125-236-193-95.adsl.xtra.co.nz [125.236.193.95]) by mini (Postfix) with ESMTPSA id 1E8D3917B7; Mon, 10 Nov 2008 15:29:37 +1300 (NZDT) User-Agent: KMail/1.10.1 (Linux/2.6.27-7-generic; KDE/4.1.3; i686; ; ) In-Reply-To: Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Greylist: delayed 1505 seconds by postgrey-1.27 at monty-python; Sun, 09 Nov 2008 21:54:44 EST X-Mailman-Approved-At: Sun, 09 Nov 2008 22:27:28 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105524 Archived-At: On Mon, 10 Nov 2008 04:03:05 Stefan Monnier wrote: > > I'm offering this patch for review before I commit, since I'm not > > an expert in the VC code. Following the patch is a shell script > > showing the reproduction recipe. > > I don't really like this, because links can also be used for other > purposes than "copy on write". Most importantly your patch breaks > symlinks, which is usually the wrong thing to do. > > In my opinion, the use of hardlinked trees is just risky business > that requires a lot of care, so I think priority should be given to > handle the "non-hardlinked tree" case correctly. Can we at least have an option to have emacs break hard links on edit? This bit me when my ubuntu laptop was upgraded to intrepid, which upgraded my emacs which brought with it a newer vc module which automagically detected files that were in a bzr branch. Previously backup copies were being made, which caused the had links to be broken. When the files were detected to be in source control, emacs (correctly in my opinion) stopped attempting to create backup files. My issue was that my workflow suddenly got screwed up. I'm not suggesting that the default behaviour necessarily be changed for everything, but I'd like the ability to have emacs brake my hardlinks on edit for my bzr hosted files. Tim