unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tim Penhey <tim@penhey.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Karl Fogel <kfogel@red-bean.com>, Barry Warsaw <barry@python.org>,
	Emacs Development <emacs-devel@gnu.org>
Subject: Re: [PATCH] vc-bzr.el: avoid stomping files across hardlink branches.
Date: Mon, 10 Nov 2008 15:29:35 +1300	[thread overview]
Message-ID: <200811101529.36589.tim@penhey.net> (raw)
In-Reply-To: <jwvabc96ji1.fsf-monnier+emacs@gnu.org>

On Mon, 10 Nov 2008 04:03:05 Stefan Monnier wrote:
> > I'm offering this patch for review before I commit, since I'm not
> > an expert in the VC code.  Following the patch is a shell script
> > showing the reproduction recipe.
>
> I don't really like this, because links can also be used for other
> purposes than "copy on write".  Most importantly your patch breaks
> symlinks, which is usually the wrong thing to do.
>
> In my opinion, the use of hardlinked trees is just risky business
> that requires a lot of care, so I think priority should be given to
> handle the "non-hardlinked tree" case correctly.

Can we at least have an option to have emacs break hard links on edit?

This bit me when my ubuntu laptop was upgraded to intrepid, which 
upgraded my emacs which brought with it a newer vc module which 
automagically detected files that were in a bzr branch.  Previously 
backup copies were being made, which caused the had links to be broken.  
When the files were detected to be in source control, emacs (correctly in 
my opinion) stopped attempting to create backup files.  My issue was that 
my workflow suddenly got screwed up.

I'm not suggesting that the default behaviour necessarily be changed for 
everything, but I'd like the ability to have emacs brake my hardlinks on 
edit for my bzr hosted files.

Tim




  reply	other threads:[~2008-11-10  2:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200810292207.58558.tim@penhey.net>
2008-11-09  3:44 ` [PATCH] vc-bzr.el: avoid stomping files across hardlink branches Karl Fogel
2008-11-09  4:33   ` Miles Bader
2008-11-09  4:44     ` Karl Fogel
2008-11-09 15:03   ` Stefan Monnier
2008-11-10  2:29     ` Tim Penhey [this message]
2008-11-10  3:31       ` Stefan Monnier
2008-11-10 22:39         ` Karl Fogel
2008-11-11  2:47           ` Stefan Monnier
2008-11-29 19:05             ` Karl Fogel
2008-12-01 20:10   ` vc-dir header for bzr (was: Re: [PATCH] vc-bzr.el: avoid stomping files across hardlink branches.) Dan Nicolaescu
2008-12-01 20:30     ` vc-dir header for bzr Karl Fogel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811101529.36589.tim@penhey.net \
    --to=tim@penhey.net \
    --cc=barry@python.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).