From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: tool-bar related errors when loading compile.el Date: Mon, 6 Oct 2008 03:08:37 -0700 (PDT) Message-ID: <200810061008.m96A8bpK002906@mothra.ics.uci.edu> References: <200810060547.m965lUCa002112@mothra.ics.uci.edu> <48E9A921.2040200@gmx.at> <200810060704.m9674Eph002629@mothra.ics.uci.edu> <48E9DC4A.1040009@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1223287792 23416 80.91.229.12 (6 Oct 2008 10:09:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Oct 2008 10:09:52 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 06 12:10:50 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kmn39-0001eX-Mb for ged-emacs-devel@m.gmane.org; Mon, 06 Oct 2008 12:10:47 +0200 Original-Received: from localhost ([127.0.0.1]:51501 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmn26-0005qD-4H for ged-emacs-devel@m.gmane.org; Mon, 06 Oct 2008 06:09:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kmn1z-0005pz-3Z for emacs-devel@gnu.org; Mon, 06 Oct 2008 06:09:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kmn1x-0005pb-KP for emacs-devel@gnu.org; Mon, 06 Oct 2008 06:09:34 -0400 Original-Received: from [199.232.76.173] (port=43453 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kmn1x-0005pY-BK for emacs-devel@gnu.org; Mon, 06 Oct 2008 06:09:33 -0400 Original-Received: from sallyv2.ics.uci.edu ([128.195.1.120]:49268) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1Kmn1v-0006Gw-8c; Mon, 06 Oct 2008 06:09:31 -0400 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m96A8cLN015245; Mon, 6 Oct 2008 03:08:39 -0700 (PDT) Original-Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m96A8bpK002906; Mon, 6 Oct 2008 03:08:37 -0700 (PDT) In-Reply-To: <48E9DC4A.1040009@gmx.at> (martin rudalics's message of "Mon, 06 Oct 2008 11:37:14 +0200") Original-Lines: 26 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m96A8cLN015245 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104374 Archived-At: martin rudalics writes: > > > (if (display-graphic-p) > > ^^^^^^^^^^^^^^^^^ > > Using this in defvars is broken. If you start with "emacs -nw" and > > later create X11 frames, the defvar will not be initialized correctly > > for X11 frames. > > > > > into > > > > > > (if tool-bar-mode > > > > > > in compile.el and grep.el. > > > > Unfortunately that is not better for the same reason. > > So even if we made `compilation-mode-tool-bar-map' a function and did > > (when tool-bar-mode > (set (make-local-variable 'tool-bar-map) > (compilation-mode-tool-bar-map))) > > in `compilation-mode' we'd miss something? I think so, when the buffer is initialized tool-bar-mode can be off, but when it's displayed the user could have turned it on.