From: Dan Nicolaescu <dann@ics.uci.edu>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org, Miles Bader <miles@gnu.org>
Subject: Re: tool-bar related errors when loading compile.el
Date: Mon, 6 Oct 2008 03:08:37 -0700 (PDT) [thread overview]
Message-ID: <200810061008.m96A8bpK002906@mothra.ics.uci.edu> (raw)
In-Reply-To: <48E9DC4A.1040009@gmx.at> (martin rudalics's message of "Mon, 06 Oct 2008 11:37:14 +0200")
martin rudalics <rudalics@gmx.at> writes:
> > > (if (display-graphic-p)
> > ^^^^^^^^^^^^^^^^^
> > Using this in defvars is broken. If you start with "emacs -nw" and
> > later create X11 frames, the defvar will not be initialized correctly
> > for X11 frames.
> >
> > > into
> > >
> > > (if tool-bar-mode
> > >
> > > in compile.el and grep.el.
> >
> > Unfortunately that is not better for the same reason.
>
> So even if we made `compilation-mode-tool-bar-map' a function and did
>
> (when tool-bar-mode
> (set (make-local-variable 'tool-bar-map)
> (compilation-mode-tool-bar-map)))
>
> in `compilation-mode' we'd miss something?
I think so, when the buffer is initialized tool-bar-mode can be off, but
when it's displayed the user could have turned it on.
prev parent reply other threads:[~2008-10-06 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 5:20 tool-bar related errors when loading compile.el Miles Bader
2008-10-06 5:47 ` Dan Nicolaescu
2008-10-06 5:58 ` martin rudalics
2008-10-06 7:04 ` Dan Nicolaescu
2008-10-06 9:37 ` martin rudalics
2008-10-06 10:08 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810061008.m96A8bpK002906@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).