From: Dan Nicolaescu <dann@ics.uci.edu>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: emacs- devel <emacs-devel@gnu.org>
Subject: Re: warnings on gnustep
Date: Wed, 20 Aug 2008 23:20:50 -0700 [thread overview]
Message-ID: <200808210620.m7L6KoN8016084@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <6EF7D92A-4643-453E-928A-832C5C8430C4@gmail.com> (Adrian Robert's message of "Wed, 20 Aug 2008 22:50:46 -0400")
Adrian Robert <adrian.b.robert@gmail.com> writes:
> On Aug 6, 2008, at 11:41 PM, Dan Nicolaescu wrote:
>
> > I managed to get access to a machine that has a gnustep
> > installation. I
> > get these warnings when compiling the ns*.m files.
> >
> > The 'lrint' looks strange, on my Fedora systems lrint is in <math.h>
> > which is included. I haven't looked at why this happens.
>
> Some brief googling suggests this has something to do with various C
> standards and arguments like -std=c99. I don't understand this at
> all, but if you look in that math.h are the lrint definitions
> protected by any ifdefs? Also I wonder what effect that -D_BSD_SOURCE
> has and where is that coming from?
This is an artifact of not including config.h first, do that and it goes
away. -D_BSD_SOURCE comes from s/gnu-linux.h
> > But the signal ones are probably something to worry about.
>
> Which ones are you talking about? (The word "signal" is not appearing
> in the warnings below.)
Sorry, I meant messages.
> > BTW, I think that the includes need to be reordered, if you look in
> > all
> > the other files in emacs config.h is the first file included, that is
> > not the case in the ns*.m files.
>
> Hmm, these other files also seem to include <config.h>, as if it's a
> system include, rather than "config.h". I don't understand why. The
> NS files include system includes first, then local ones, and
> "config.h" is the first of these.
config.h is supposed to be the first file included, and the standard
files included based on what config.h defines, see for example in other
files:
#ifdef HAVE_UNISTD_H
#include <unistd.h>
#endif
Thanks for taking care of the rest of the warnings.
--dan
prev parent reply other threads:[~2008-08-21 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200808070341.m773fZMo028893@sallyv1.ics.uci.edu>
2008-08-21 2:50 ` warnings on gnustep Adrian Robert
2008-08-21 6:20 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808210620.m7L6KoN8016084@sallyv1.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).