From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Glenn Morris <rgm@gnu.org>, Chong Yidong <cyd@stupidchicken.com>,
emacs-devel@gnu.org
Subject: Re: Refactoring of emacs-lisp/autoload.el
Date: Thu, 14 Aug 2008 13:17:39 +0000 [thread overview]
Message-ID: <20080814131739.GD2593@muc.de> (raw)
In-Reply-To: <jwvbpzw8y6o.fsf-monnier+emacs@gnu.org>
Hi, Stefan!
On Wed, Aug 13, 2008 at 04:31:14PM -0400, Stefan Monnier wrote:
> > OK. I haven't yet characterised fully the criterion for a file being
> > in this list. I'm looking at that now.
> Normally, all files should appear in loaddefs.el: either they have their
> own section or they're in the "nothing to declare" section.
> If there are a couple files not mentioned there, it's not tragic, tho.
Ah, got it! It was just I thought I'd seen a file with its own section
which was also in the "innocent" section at the end. I've had a look for
this, and can't find it. So I must have been mistaken.
> The goal is that running "cd emacs/lisp; make autoloads" after
> loaddefs.el has just been updated should only need to scan loaddefs.el,
> and check the timestamp of all the .el files, and can then return
> without reading any of the other (unchanged) elisp files, so that "make
> autoloads" is almost immediate when it has nothing to do.
OK. This is obviously very important. The patch I posted here isn't up
to scratch for that. I'll need to improve it.
> > My strategy when inserting a new entry into loaddefs.el is to start
> > searching from the current position in that file. So if the source
> > files are processed in alphabetical order, the newer autoload.el
> > should be just as fast (or, at least, fast enough).
> Yes, that sounds fine.
What I'll be doing is sorting the "no-autoloads" list so that it's in the
same order as the file entries. I can then loop through all the files,
testing in turn whether the file was a "no-autoload" or had its own
section, and take the appropriate action. That will mean never having to
search loaddefs.el for an entry, and not having to use `member' in the
"no-autoloads" list, since I will be stepping through both from start to
finish.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2008-08-14 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 16:23 Refactoring of emacs-lisp/autoload.el Alan Mackenzie
2008-08-12 20:09 ` Stefan Monnier
2008-08-12 20:58 ` Glenn Morris
2008-08-13 14:13 ` Alan Mackenzie
2008-08-13 16:11 ` Glenn Morris
2008-08-13 14:11 ` Alan Mackenzie
2008-08-13 20:31 ` Stefan Monnier
2008-08-14 13:17 ` Alan Mackenzie [this message]
2008-08-14 17:52 ` Stefan Monnier
2008-09-01 21:55 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814131739.GD2593@muc.de \
--to=acm@muc.de \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).