From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: fixing non-NS darwin Date: Sun, 03 Aug 2008 19:26:24 -0700 Message-ID: <200808040226.m742QOgN023296@sallyv1.ics.uci.edu> References: <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu> <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu> <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> <200808040120.m741K6YQ001518@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217816873 28200 80.91.229.12 (4 Aug 2008 02:27:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2008 02:27:53 +0000 (UTC) Cc: Adrian Robert , Emanuele Giaquinta , Emacs Development To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 04 04:28:43 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KPpoO-0001Sa-HO for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2008 04:28:40 +0200 Original-Received: from localhost ([127.0.0.1]:56365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPpnS-0003qt-I2 for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2008 22:27:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPpnN-0003qL-Ao for emacs-devel@gnu.org; Sun, 03 Aug 2008 22:27:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPpnL-0003q8-Bw for emacs-devel@gnu.org; Sun, 03 Aug 2008 22:27:37 -0400 Original-Received: from [199.232.76.173] (port=41417 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPpnL-0003q5-8z for emacs-devel@gnu.org; Sun, 03 Aug 2008 22:27:35 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:57243) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KPpnK-0000Tr-CF for emacs-devel@gnu.org; Sun, 03 Aug 2008 22:27:35 -0400 X-ICS-MailScanner-Watermark: 1218421587.80909@k9EkBMd4Z/Cn/U5tNkkjlQ Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m742QOgN023296; Sun, 3 Aug 2008 19:26:25 -0700 (PDT) In-Reply-To: (YAMAMOTO Mitsuharu's message of "Mon, 04 Aug 2008 11:03:11 +0900") Original-Lines: 47 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102022 Archived-At: YAMAMOTO Mitsuharu writes: > >>>>> On Sun, 03 Aug 2008 18:20:05 -0700, Dan Nicolaescu said: > > >> > This is not defined anywhere in emacs, but there was this section in > >> > an earlier version of darwin.h: > >> > >> > #if 0 /* Don't define DARWIN on Mac OS X because CoreFoundation.h uses > >> > it to distinguish Mac OS X from bare Darwin. */ > >> > #ifndef DARWIN > >> > #define DARWIN 1 > >> > #endif > >> > #endif > >> > >> > Does anyone know where this IS defined? Also, I've been unable to > >> > find a version of CoreFoundation.h that makes the check referred to. > >> > >> It's used in CoreFoundation.h in Mac OS X 10.1 - 10.3. > >> > >> BTW, why the above comment was removed? > > > Because it looked like dead code, and the description was not something > > that made it clear that it was needed as documentation, nor was the > > structure of the code. > > It's quite a common way in the Emacs code to comment out with #if 0 > with leaving some explanation about why it is disabled. Especially > for the case that people might make the same mistake again in future > unconsciously if that part were completely removed. So? Everyone is aware of that. But that was absolutely not the case in this particular instance. The comments and code did not make the intention clear for the casual reader. If you actually want to contribute something positive, please add the missing documentation and fix the code. > Cleanup tasks are usually tedious, and thus would be much appreciated > if done carefully and appropriately. But as they are also inherently > optional, not appreciated if done less carefully or unnecessarily > aggressively as in the case of MULTI_KBOARD. Did you just wait for an occasion to attack me on an unrelated item? Grow up! Sorry, I am not interested in your badgering, and given you past abhorrent behavior you are not in a position to lecture anyone. Do I have to repeat it yet again? STOP WAISTING MY TIME!