From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: a review of the merge (Re: Emacs.app merged) Date: Fri, 01 Aug 2008 08:07:18 -0700 Message-ID: <200808011507.m71F7IKF005086@sallyv1.ics.uci.edu> References: <1C66F1FC-BF82-4365-944D-ADCC4D1F435C@gmail.com> <200807160925.m6G9PuVj012462@sallyv1.ics.uci.edu> <200807162123.m6GLNmIw021022@sallyv1.ics.uci.edu> <200807201156.m6KBus7O008807@sallyv1.ics.uci.edu> <925D787C-541B-49DC-B44C-EDA950E0F738@gmail.com> <200807281900.m6SJ0dYa010587@sallyv1.ics.uci.edu> <4892EECE.4070605@gnu.org> <200808011255.m71Cts72014909@sallyv1.ics.uci.edu> <48931481.6070107@gnu.org> <200808011423.m71ENlMa011262@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217603765 3431 80.91.229.12 (1 Aug 2008 15:16:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Aug 2008 15:16:05 +0000 (UTC) Cc: emacs- devel , Jason Rumney To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 01 17:16:55 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOwMg-0007hd-64 for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 17:16:23 +0200 Original-Received: from localhost ([127.0.0.1]:48863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOwLk-0004K2-6u for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 11:15:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOwGD-0000Xt-Us for emacs-devel@gnu.org; Fri, 01 Aug 2008 11:09:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOwGA-0000UK-Lb for emacs-devel@gnu.org; Fri, 01 Aug 2008 11:09:41 -0400 Original-Received: from [199.232.76.173] (port=52324 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOwGA-0000UA-8R for emacs-devel@gnu.org; Fri, 01 Aug 2008 11:09:38 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:53719) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KOwFx-0007KC-1h; Fri, 01 Aug 2008 11:09:26 -0400 X-ICS-MailScanner-Watermark: 1218208038.88762@enlNDCo1i82m+m/XB9z++g Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m71F7IKF005086; Fri, 1 Aug 2008 08:07:18 -0700 (PDT) In-Reply-To: (Adrian Robert's message of "Fri, 1 Aug 2008 10:48:46 -0400") Original-Lines: 23 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101895 Archived-At: Adrian Robert writes: > On Aug 1, 2008, at 10:23 AM, Dan Nicolaescu wrote: > > > Now IMHO: I'd say that the w32 function can be removed because it is > > not > > very useful, and the data in etc/rgb.txt be put in a static struct > > in a > > C file and use it from there. > > Having it in rgb.txt makes it easy to upgrade when X changes this file > (which it does from time to time). It does? Is it often enough to worry about it? > What about best of both worlds, some sort of compile-time awk > operation that generates a C file from etc/rgb.txt? It would be better if the C file was checked in the repository (like we do for example with the "configure" script). And it would be even better if we didn't have the etc/rgb.txt file at all, (it get needlessly installed on GNU/Linux for example), just the script that processes the standard X11 rgb.txt and produces the C file.