From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: a review of the merge (Re: Emacs.app merged) Date: Fri, 01 Aug 2008 05:55:54 -0700 Message-ID: <200808011255.m71Cts72014909@sallyv1.ics.uci.edu> References: <1C66F1FC-BF82-4365-944D-ADCC4D1F435C@gmail.com> <200807160925.m6G9PuVj012462@sallyv1.ics.uci.edu> <200807162123.m6GLNmIw021022@sallyv1.ics.uci.edu> <200807201156.m6KBus7O008807@sallyv1.ics.uci.edu> <925D787C-541B-49DC-B44C-EDA950E0F738@gmail.com> <200807281900.m6SJ0dYa010587@sallyv1.ics.uci.edu> <4892EECE.4070605@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217596311 7534 80.91.229.12 (1 Aug 2008 13:11:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Aug 2008 13:11:51 +0000 (UTC) Cc: Adrian Robert , emacs- devel To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 01 15:12:38 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOuQq-0005ef-3e for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 15:12:32 +0200 Original-Received: from localhost ([127.0.0.1]:56417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOuPv-0006SA-DN for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 09:11:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOuCM-0002Rx-5N for emacs-devel@gnu.org; Fri, 01 Aug 2008 08:57:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOuCH-0002QB-DV for emacs-devel@gnu.org; Fri, 01 Aug 2008 08:57:33 -0400 Original-Received: from [199.232.76.173] (port=51192 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOuCG-0002Po-W1 for emacs-devel@gnu.org; Fri, 01 Aug 2008 08:57:29 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:38265) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KOuCA-0004W9-IK; Fri, 01 Aug 2008 08:57:22 -0400 X-ICS-MailScanner-Watermark: 1218200154.80943@GrGAY4yLMMrCOnWbZsDtVw Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m71Cts72014909; Fri, 1 Aug 2008 05:55:54 -0700 (PDT) In-Reply-To: <4892EECE.4070605@gnu.org> (Jason Rumney's message of "Fri, 01 Aug 2008 12:09:02 +0100") Original-Lines: 19 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101874 Archived-At: Jason Rumney writes: > Adrian Robert wrote: > > > Hi Jason, > > > > Do you have any objection to moving/renaming w32-load-color-file to > > xfaces.c so the NS port can use it? Also, does it need to be exposed to > > lisp (syms_of...)? It's not called from anywhere in the emacs tree lisp > > anyway. > > No objection to renaming, I guess the export to lisp is so users can > override the color names with their own rgb.txt file, though I suspect > the number of users who do so is pretty close to zero. If the number is close to zero, then should we even consider giving such an option? We have too many knobs in emacs anyway, why add one that we know won't be used? And IMHO overriding color names is not something we want to allow...