From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: Removing MULTI_KBOARD Date: Wed, 30 Jul 2008 20:43:01 -0700 Message-ID: <200807310343.m6V3h1Zo006813@sallyv1.ics.uci.edu> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1217475934 12339 80.91.229.12 (31 Jul 2008 03:45:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jul 2008 03:45:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 31 05:46:23 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOP7P-0002WX-IZ for ged-emacs-devel@m.gmane.org; Thu, 31 Jul 2008 05:46:23 +0200 Original-Received: from localhost ([127.0.0.1]:53762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOP6V-00009g-8N for ged-emacs-devel@m.gmane.org; Wed, 30 Jul 2008 23:45:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOP6R-00008E-9V for emacs-devel@gnu.org; Wed, 30 Jul 2008 23:45:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOP6P-000064-Mj for emacs-devel@gnu.org; Wed, 30 Jul 2008 23:45:21 -0400 Original-Received: from [199.232.76.173] (port=59924 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOP6P-00005z-F8 for emacs-devel@gnu.org; Wed, 30 Jul 2008 23:45:21 -0400 Original-Received: from sallyv1.ics.uci.edu ([128.195.1.109]:61058) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KOP6L-0005KF-4P; Wed, 30 Jul 2008 23:45:17 -0400 X-ICS-MailScanner-Watermark: 1218080582.21755@2QHFG9YwAKjRWOs83/d1Ow Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv1.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m6V3h1Zo006813; Wed, 30 Jul 2008 20:43:01 -0700 (PDT) In-Reply-To: (Eli Zaretskii's message of "Thu, 31 Jul 2008 06:19:10 +0300") Original-Lines: 36 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101781 Archived-At: Eli Zaretskii writes: > > Date: Wed, 30 Jul 2008 22:47:53 -0400 > > From: emacs-diffs-request@gnu.org > > > > --- src/ChangeLog 30 Jul 2008 21:45:32 -0000 1.6815 > > +++ src/ChangeLog 31 Jul 2008 02:47:26 -0000 1.6816 > > @@ -1,3 +1,24 @@ > > +2008-07-31 Dan Nicolaescu > > + > > + * s/ms-w32.h (MULTI_KBOARD): Remove. > > + * xterm.c: > > + * xselect.c: > > + * xfns.c: > > + * window.c: > > + * w32term.c: > > + * w32fns.c: > > + * terminal.c: > > + * termhooks.h: > > + * term.c: > > + * sysdep.c: > > + * keyboard.h: > > + * keyboard.c: > > + * frame.h: > > + * frame.c: > > + * frame.c: Remove references to MULTI_KBOARD, it is now the > > + default. > > Did we agree to remove these conditionals? The MS-DOS port does not > support MULTI_KBOARD, so now it is more broken than it was before. The code now is cleaner and easier to read. Unused code does not get in your way as it used to happen before. The difference in usage from a port point a view is minimal: a single static object vs a single dynamically allocated object. The full history is available in CVS.