unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@ics.uci.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Removing MULTI_KBOARD
Date: Wed, 30 Jul 2008 20:43:01 -0700	[thread overview]
Message-ID: <200807310343.m6V3h1Zo006813@sallyv1.ics.uci.edu> (raw)
In-Reply-To: <uljzioi4x.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 31 Jul 2008 06:19:10 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

  > > Date: Wed, 30 Jul 2008 22:47:53 -0400
  > > From: emacs-diffs-request@gnu.org
  > > 
  > > --- src/ChangeLog	30 Jul 2008 21:45:32 -0000	1.6815
  > > +++ src/ChangeLog	31 Jul 2008 02:47:26 -0000	1.6816
  > > @@ -1,3 +1,24 @@
  > > +2008-07-31  Dan Nicolaescu  <dann@ics.uci.edu>
  > > +
  > > +	* s/ms-w32.h (MULTI_KBOARD): Remove.
  > > +	* xterm.c:
  > > +	* xselect.c:
  > > +	* xfns.c:
  > > +	* window.c:
  > > +	* w32term.c:
  > > +	* w32fns.c:
  > > +	* terminal.c:
  > > +	* termhooks.h:
  > > +	* term.c:
  > > +	* sysdep.c:
  > > +	* keyboard.h:
  > > +	* keyboard.c:
  > > +	* frame.h:
  > > +	* frame.c:
  > > +	* frame.c: Remove references to MULTI_KBOARD, it is now the
  > > +	default.
  > 
  > Did we agree to remove these conditionals?  The MS-DOS port does not
  > support MULTI_KBOARD, so now it is more broken than it was before.

The code now is cleaner and easier to read.  Unused code does not get in
your way as it used to happen before.
The difference in usage from a port point a view is minimal: a single
static object vs a single dynamically allocated object. The full history
is available in CVS.




  reply	other threads:[~2008-07-31  3:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1KOODr-0006yO-BJ@monty-python.gnu.org>
2008-07-31  3:19 ` Removing MULTI_KBOARD Eli Zaretskii
2008-07-31  3:43   ` Dan Nicolaescu [this message]
2008-07-31 18:09     ` Eli Zaretskii
2008-07-31 19:21       ` Dan Nicolaescu
2008-08-01  7:03         ` Eli Zaretskii
2008-08-01 12:09           ` Dan Nicolaescu
2008-08-01 12:20             ` Juanma Barranquero
2008-08-02  5:12               ` Richard M Stallman
2008-08-02  6:55                 ` Dan Nicolaescu
2008-08-02  7:45                   ` Eli Zaretskii
2008-08-02  9:27                     ` Dan Nicolaescu
2008-08-02  9:38                       ` Eli Zaretskii
2008-08-02 10:10                         ` Jason Rumney
2008-08-02 14:07                           ` Chong Yidong
2008-08-02 17:29                             ` Eli Zaretskii
2008-08-02 22:49                             ` Nick Roberts
2008-08-02 23:58                               ` Lennart Borgman (gmail)
2008-08-03  3:24                               ` Eli Zaretskii
2008-08-03 18:20                               ` Stefan Monnier
2008-08-04  1:15                                 ` Dan Nicolaescu
2008-08-04 19:10                                   ` Stefan Monnier
2008-08-05  3:25                                     ` Eli Zaretskii
2008-08-07 19:37                                       ` Stefan Monnier
2008-08-12 18:08                                         ` Eli Zaretskii
2008-08-23 18:05                                           ` Eli Zaretskii
2008-08-23 18:24                                             ` Dan Nicolaescu
2008-08-23 19:03                                               ` Eli Zaretskii
2008-08-23 19:13                                                 ` Dan Nicolaescu
2008-08-23 20:15                                                   ` Eli Zaretskii
2008-08-23 21:01                                                     ` Dan Nicolaescu
2008-08-24  5:34                                                   ` Richard M. Stallman
2008-08-24  9:36                                                     ` Dan Nicolaescu
2008-08-24 10:15                                                       ` Juanma Barranquero
2008-08-24 18:21                                                     ` Eli Zaretskii
2008-08-26 21:32                                                   ` Stefan Monnier
2008-08-23 20:18                                             ` Chong Yidong
2008-08-23 20:53                                               ` Eli Zaretskii
2008-08-26 21:35                                             ` Stefan Monnier
2008-08-03  5:53                             ` Miles Bader
2008-08-03  1:32                       ` Richard M. Stallman
2008-08-03  1:33                   ` Richard M. Stallman
2008-08-01 13:30             ` Eli Zaretskii
2008-08-01 13:41               ` Dan Nicolaescu
2008-08-01 13:54                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807310343.m6V3h1Zo006813@sallyv1.ics.uci.edu \
    --to=dann@ics.uci.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).